-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package flake #685
Add package flake #685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe making the step use:
cargo install dora-cli --locked
Might make this file simpler and remove the need to fetch from github, having to copy around binaries.
What do you think?
{ lib, fetchFromGitHub, rustPlatform }:
rustPlatform.buildRustPackage rec {
pname = "ripgrep";
version = "12.1.1";
src = fetchFromGitHub {
owner = "BurntSushi";
repo = pname;
rev = version;
hash = "sha256-+s5RBC3XSgb8omTbUNLywZnP6jSxZBKSS1BmXOjRF8M=";
};
cargoHash = "sha256-jtBw4ahSl88L0iuCXxQgZVm1EcboWRJMNtjxLVTtzts=";
meta = {
description = "Fast line-oriented regex search tool, similar to ag and ack";
homepage = "https://github.com/BurntSushi/ripgrep";
license = lib.licenses.unlicense;
maintainers = [ ];
};
}
I'll give that a try |
not a adding the install step means that the system doesn't have access to the binary. I'm not entirely sure why that's the case, as distributing rust binaries is not a rabbit hole I've dived down, but I suspect it relates to the install-from-source instruction where you build a package and add
I'm not exactly sure what you mean by this. |
I understand thanks for trying! I'll merge it in that case as is :) Thanks a lot :) |
I'll put it to the test today, and report back. I'll also probably need to add some CI/CD stuff to make sure that the nix-install approach works. Thanks for the merge :) |
This means that someone using nix can add this to their flake inputs:
and that allows them to add dora-cli, v0.3.6, as one of the declared packages of the system.
This is the first step towards adding dora to the nix package repo.