Skip to content

Commit

Permalink
Merge pull request #359 from dora-rs/minor-refactoring
Browse files Browse the repository at this point in the history
Remove `Ros2Value` encapsulation of `ArrayData`
  • Loading branch information
haixuanTao authored Oct 16, 2023
2 parents 2127452 + 6898348 commit 346bc63
Show file tree
Hide file tree
Showing 14 changed files with 781 additions and 565 deletions.
55 changes: 52 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,32 @@ jobs:
platform: [ubuntu-latest, macos-latest, windows-latest]
fail-fast: false
runs-on: ${{ matrix.platform }}
timeout-minutes: 30
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
- run: cargo --version --verbose
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: false

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: false
- name: Free disk Space (Windows)
if: runner.os == 'Windows'
run: |
docker system prune --all -f
Remove-Item "C:\Android" -Force -Recurse
- uses: Swatinem/rust-cache@v2
with:
cache-provider: buildjet
Expand All @@ -35,7 +56,13 @@ jobs:
- name: "Build"
run: cargo build --all
- name: "Test"
# Remove Windows as there is `pdb` linker issue.
# See: https://github.com/dora-rs/dora/pull/359#discussion_r1360268497
if: runner.os == 'Linux' || runner.os == 'macOS'
run: cargo test --all
- name: "Test"
if: runner.os == 'Windows'
run: cargo test --all --lib

# Run examples as separate job because otherwise we will exhaust the disk
# space of the GitHub action runners.
Expand All @@ -51,6 +78,27 @@ jobs:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
- run: cargo --version --verbose
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: false

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: false
- name: Free disk Space (Windows)
if: runner.os == 'Windows'
run: |
docker system prune --all -f
Remove-Item "C:\Android" -Force -Recurse
- uses: Swatinem/rust-cache@v2
with:
cache-provider: buildjet
Expand Down Expand Up @@ -122,7 +170,8 @@ jobs:
env:
QT_QPA_PLATFORM: offscreen
run: |
source /opt/ros/humble/setup.bash && ros2 run turtlesim turtlesim_node &
# Reset only the turtlesim instance as it is not destroyed at the end of the previous job
source /opt/ros/humble/setup.bash && ros2 service call /reset std_srvs/srv/Empty &
cargo run --example python-ros2-dataflow --features="ros2-examples"
bench:
Expand Down Expand Up @@ -155,7 +204,7 @@ jobs:
platform: [ubuntu-latest, macos-latest, windows-latest]
fail-fast: false
runs-on: ${{ matrix.platform }}
timeout-minutes: 30
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
Expand Down
Loading

0 comments on commit 346bc63

Please sign in to comment.