Remove Ros2Value encapsulation of ArrayData
#359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
force-pushed
the
minor-refactoring
branch
from
7f17e32 to
a5ddee0
Compare
CI: Use free-disk-space only on linux free disk space for window See https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md To check what is installed on the window image Use rmdir instead of choco to uninstall Android Fix Window CI Issue FIx CI by removing android uninstall and adding time becfore checking for tick Removing cache to fix cargo pdb error See https://stackoverflow.com/questions/4256524/lnk1318-unexpected-pdb-error-ok-0 Add time before timing out for the CI to run Reduce the amount of jobs to reduce memory consumption and maybe fix parallel build error Remove rust caching as it not link to CI issue Remove android folder to add more space to window runner Removing windows from CI/CD as it does not work
haixuanTao
force-pushed
the
minor-refactoring
branch
from
a5ddee0 to
dc78bfd
Compare
haixuanTao
commented
Oct 10, 2023
phil-opp
approved these changes
Oct 16, 2023
phil-opp
changed the title
Ros2Value encapsulation of ArrayData
phil-opp
approved these changes
Oct 16, 2023
phil-opp
reviewed
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring:
ArrayDataas it is no longer needed.Arraydatainto aBufferand back as I want to make sure that it works for all types and that we don't introduce any breaking bug.