Manage node failure: Await all nodes to finish before marking dataflow as finished #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previouly, if one node failed we would immidiately mark the dataflow as finished even though other nodes might still be running. This meant that if one node failed, it would not be possible to stop the dataflow through the cli as it is marked as finished. This commit will just warn the user that one node failed but will keep await that all nodes within the dataflow finishes.
haixuanTao
force-pushed
the
manage-node-failure
branch
from
34ca554 to
917303f
Compare
phil-opp
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previouly, if one node failed we would immidiately mark the dataflow as
finished even though other nodes might still be running.
This meant that if one node failed, it would not be possible to stop the
dataflow through the cli as it is marked as finished.
This commit will just warn the user that one node failed but will keep
await that all nodes within the dataflow finishes.