Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage node failure: Await all nodes to finish before marking dataflow as finished #183

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Manage node failure: Await all nodes to finish before marking dataflow as finished #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion binaries/coordinator/src/run/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use eyre::{bail, eyre, WrapErr};
use futures::{stream::FuturesUnordered, StreamExt};
use std::{env::consts::EXE_EXTENSION, path::Path};
use tokio_stream::wrappers::IntervalStream;
use tracing::warn;
use uuid::Uuid;

mod custom;
Expand Down Expand Up @@ -135,7 +136,8 @@ pub async fn await_tasks(
while let Some(task_result) = tasks.next().await {
task_result
.wrap_err("failed to join async task")?
.wrap_err("custom node failed")?;
.wrap_err("One node failed!")
.unwrap_or_else(|err| warn!("{err}"))
}
Ok(())
}
Expand Down