Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove iceoryx dependency #201

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Remove iceoryx dependency #201

merged 1 commit into from
Mar 9, 2023

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Mar 9, 2023

We now have our own shared memory implementation, so there is no reason to keep the iceoryx implementation around.

@phil-opp
Remove iceoryx dependency
99384e3 
We now have our own shared memory implementation.
@phil-opp phil-opp requested a review from haixuanTao March 9, 2023 12:27
haixuanTao
haixuanTao approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, Thanks!

@phil-opp phil-opp enabled auto-merge March 9, 2023 12:46
@phil-opp phil-opp merged commit 8be922a into main Mar 9, 2023
@phil-opp phil-opp deleted the remove-icoryx branch March 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-opp @haixuanTao