Validate yaml when reading #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
changed the title
haixuanTao
force-pushed
the
validate-yaml
branch
from
de5a333 to
a15cf4a
Compare
…d library. And make sure that `dora-runtime` version match the `dora-core` version
haixuanTao
force-pushed
the
validate-yaml
branch
from
de66914 to
2b1ae1a
Compare
haixuanTao
added a commit
that referenced
this pull request
Apr 1, 2023
In #237, I have grouped the validation of yaml as a method of descriptor. This validation was copied from the `cli check` method. However, we did not add the validation of shell command and accept url as valid source in the original `cli check`. This Pull Request validate both sources.
haixuanTao
added a commit
that referenced
this pull request
Apr 4, 2023
In #237, I have grouped the validation of yaml as a method of descriptor. This validation was copied from the `cli check` method. However, we did not add the validation of shell command and accept url as valid source in the original `cli check`. This Pull Request validate both sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR validates YAML when been read avoiding typo and undefined behaviour.
The implementation is done as follows:
read_descriptionand address it withreadandblocking_read(inspired by tokio) as a method ofdora_core::Descriptor.dora_cli::checkyaml logic into adora_corelogic.is_validis called. This is because some function requires to read the dataflow even if its not valid such asgraphandbuildThis Pull Request avoid hanging on inputs that does not exist. Such as mistyped node_id or outputs. It will generates the following error:
and: