Validate shell command as source and url source. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #237, I have grouped the validation of yaml as a method of descriptor. This validation was copied from the `cli check` method. However, we did not add the validation of shell command and accept url as valid source in the original `cli check`. This Pull Request validate both sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #237, I have centralised the validation of yaml graph, so that every process that read a yaml graph can validate it, avoiding propagating failing yaml graph.
This validation method was copied from the
cli checkmethod.However, in the original
cli check, we did not add validation for shell command and we failed source that were url.This Pull Request validate both sources.
P.S: I have left the
TODO:testing of url source as I'm not sure of what the best appropriate approach is at the moment, especially in a case of distributeddora-daemonP.S.2: I have added a small default in the Descriptor communication to remove the need to specify the communication in the yaml file.