Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ros2Value encapsulation of ArrayData #359

Merged
merged 12 commits into from
Oct 16, 2023
Merged

Remove Ros2Value encapsulation of ArrayData #359

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d18d2c
Remove unnecessary ro2value encapsulation
haixuanTao Oct 3, 2023
be49c74
Add roundtrip test for copying data into buffer and back
haixuanTao Oct 5, 2023
3c737f8
Fix clippy
haixuanTao Oct 5, 2023
efcb856
Update `Cargo.lock`
haixuanTao Oct 6, 2023
158c6ae
Reset `turtlesim` instead of spawning new instance
haixuanTao Oct 6, 2023
e0e4539
Remove rust-dataflow-url as it creates linking issue in Windows
haixuanTao Oct 6, 2023
942d0a5
Use `run.rs` instead of `run.sh`for better cross-platform usage
haixuanTao Oct 6, 2023
031c445
Fix CI no space left by removing unused GA tool
haixuanTao Oct 6, 2023
dc78bfd
Replace ephemeral link with forever link
haixuanTao Oct 9, 2023
e4d3d3e
Add comments on CI jobs
haixuanTao Oct 16, 2023
9c9cb18
CI: Test windows lib and test windows python examples
haixuanTao Oct 16, 2023
6898348
CI: Removing Window python example as they don't use the exact same p…
haixuanTao Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 52 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,32 @@ jobs:
platform: [ubuntu-latest, macos-latest, windows-latest]
fail-fast: false
runs-on: ${{ matrix.platform }}
timeout-minutes: 30
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
- run: cargo --version --verbose
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: false

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: false
- name: Free disk Space (Windows)
if: runner.os == 'Windows'
run: |
docker system prune --all -f
Remove-Item "C:\Android" -Force -Recurse
- uses: Swatinem/rust-cache@v2
with:
cache-provider: buildjet
Expand All @@ -35,7 +56,13 @@ jobs:
- name: "Build"
run: cargo build --all
- name: "Test"
# Remove Windows as there is `pdb` linker issue.
# See: https://github.com/dora-rs/dora/pull/359#discussion_r1360268497
if: runner.os == 'Linux' || runner.os == 'macOS'
phil-opp marked this conversation as resolved.
Show resolved Hide resolved
run: cargo test --all
- name: "Test"
if: runner.os == 'Windows'
run: cargo test --all --lib

# Run examples as separate job because otherwise we will exhaust the disk
# space of the GitHub action runners.
Expand All @@ -51,6 +78,27 @@ jobs:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
- run: cargo --version --verbose
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: false

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: false
- name: Free disk Space (Windows)
if: runner.os == 'Windows'
run: |
docker system prune --all -f
Remove-Item "C:\Android" -Force -Recurse
- uses: Swatinem/rust-cache@v2
with:
cache-provider: buildjet
Expand All @@ -77,14 +125,11 @@ jobs:

# python examples
- uses: actions/setup-python@v2
if: runner.os == 'Linux' || runner.os == 'macOS'
with:
python-version: "3.10"
- name: "Python Dataflow example"
if: runner.os == 'Linux' || runner.os == 'macOS'
haixuanTao marked this conversation as resolved.
Show resolved Hide resolved
run: cargo run --example python-dataflow
- name: "Python Operator Dataflow example"
if: runner.os == 'Linux' || runner.os == 'macOS'
run: cargo run --example python-operator-dataflow

# ROS2 bridge examples
Expand Down Expand Up @@ -122,7 +167,8 @@ jobs:
env:
QT_QPA_PLATFORM: offscreen
run: |
source /opt/ros/humble/setup.bash && ros2 run turtlesim turtlesim_node &
# Reset only the turtlesim instance as it is not destroyed at the end of the previous job
source /opt/ros/humble/setup.bash && ros2 service call /reset std_srvs/srv/Empty &
haixuanTao marked this conversation as resolved.
Show resolved Hide resolved
cargo run --example python-ros2-dataflow --features="ros2-examples"

bench:
Expand Down Expand Up @@ -155,7 +201,7 @@ jobs:
platform: [ubuntu-latest, macos-latest, windows-latest]
fail-fast: false
runs-on: ${{ matrix.platform }}
timeout-minutes: 30
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- uses: r7kamura/[email protected]
Expand Down
Loading
Loading