Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file-based logging in daemon and coordinator #549

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

phil-opp
Copy link
Collaborator

  • Log deamon and coordinator output to files
  • Use compact formatting for stdout logs
  • Include machine ID in daemon log file name if set

Builds upon #548

phil-opp added 3 commits June 12, 2024 14:28
Logs the deamon output to `out/dora-daemon.txt` and the coordinator output to `out/dora-coordinator.txt`.
We now have the full logs in the output file.
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from less-verbose-daemon to main June 12, 2024 16:45
@phil-opp phil-opp merged commit 14ee0b6 into main Jun 12, 2024
17 of 18 checks passed
@phil-opp phil-opp deleted the file-logging branch June 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants