Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn daemon and coordinator in quiet mode on dora up #550

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

phil-opp
Copy link
Collaborator

Avoids clobbering the stdout with daemon and coordinator log messages. The logs are still available as files.

Builds upon #549

@haixuanTao
Copy link
Collaborator

I find it confusing that there is an argument --quiet for coordinator and daemon which is required but not when using up

@phil-opp
Copy link
Collaborator Author

The flag is optional, not required.

For dora up, we immediately return after spawning the commands in the background. The user will likely reuse this terminal to run other commands. Printing to stdout would then insert daemon/coordinator output at random places into the output of the other command. So I think it makes sense to ignore that output instead for dora daemon and dora coordinator.

Instead of passing a --quiet flag, we could also send the stdout to /dev/null when spawning the process.

For the dora daemon and dora coordinator commands, the situation is different. Those commands block the terminal until the daemon or coordinator exits (or you do ctrl+c). So there is nothing else running in parallel in that terminal. Thus, I think it's fine to see warnings and errors printed to the terminal.

Base automatically changed from less-verbose-daemon to main June 12, 2024 16:45
@phil-opp phil-opp merged commit eda09cb into main Jun 12, 2024
17 of 18 checks passed
@phil-opp phil-opp deleted the quiet-up branch June 12, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants