Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blazor] Drop explicit change of extension of assembly to lazy load #47901

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 26, 2023

  • In [blazor] Use JSImport for lazy loading assemblies #46437 made an explicit change of extension of assembly to lazy load to .dll
  • This change now conflicts with support for .webcil
  • The assembly (file) name comes from the user and it's validated before that it points to an existing file, so the explicit change of extension is void even for .dll scenario (the user must have provided name with .dll)
  • It would be better if users would be providing only assembly name, without extension at all, incuding BlazorWebAssemblyLazyLoad MSBuild item, but that is probably a breaking change

I would like to backport this change to preview4 if possible, so that webcil support is complete

@maraf maraf added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Apr 26, 2023
@maraf maraf added this to the 8.0-preview5 milestone Apr 26, 2023
@maraf maraf requested a review from pavelsavara April 26, 2023 10:36
@maraf maraf requested a review from a team as a code owner April 26, 2023 10:36
@maraf maraf self-assigned this Apr 26, 2023
@maraf maraf merged commit 015ceab into dotnet:main Apr 26, 2023
@maraf maraf deleted the BlazorWebcilLazyLoad branch April 26, 2023 12:28
@maraf
Copy link
Member Author

maraf commented Apr 26, 2023

/backport to release/8.0-preview4

@ghost
Copy link

ghost commented Apr 26, 2023

Hi @maraf. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@github-actions
Copy link
Contributor

Started backporting to release/8.0-preview4: https://github.com/dotnet/aspnetcore/actions/runs/4808664707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants