Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview4] [blazor] Drop explicit change of extension of assembly to lazy load #47905

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 26, 2023

Backport of #47901 to release/8.0-preview4

/cc @maraf

[blazor] Drop explicit change of extension of assembly to lazy load

Description

  • In [blazor] Use JSImport for lazy loading assemblies #46437 made an explicit change of extension of assembly to lazy load to .dll
  • This change now conflicts with support for .webcil
  • The assembly (file) name comes from the user and it's validated before that it points to an existing file, so the explicit change of extension is void even for .dll scenario (the user must have provided name with .dll)
  • It would be better if users would be providing only assembly name, without extension at all, incuding BlazorWebAssemblyLazyLoad MSBuild item, but that is probably a breaking change

I would like to backport this change to preview4 if possible, so that webcil support is complete

Customer Impact

Fix support for lazy assembly loading in webcil format

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested a review from a team as a code owner April 26, 2023 12:29
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Apr 26, 2023
@pavelsavara pavelsavara requested a review from javiercn April 26, 2023 12:31
@maraf maraf self-assigned this Apr 26, 2023
@maraf maraf added the feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly label Apr 26, 2023
@maraf maraf added this to the 8.0-preview4 milestone Apr 26, 2023
@lewing lewing added the Servicing-consider Shiproom approval is required for the issue label Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@maraf maraf added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@wtgodbe wtgodbe merged commit d60110f into release/8.0-preview4 Apr 27, 2023
@wtgodbe wtgodbe deleted the backport/pr-47901-to-release/8.0-preview4 branch April 27, 2023 16:36
@ghost ghost modified the milestone: 8.0-preview4 Apr 27, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants