Update SkiaSharp #26373
Open
Update SkiaSharp #26373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the ABI breaks are acceptable, I can do it in this PR or in a separate one. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no suggestions.
Files not reviewed (7)
- eng/Versions.props: Language not supported
- src/Graphics/samples/GraphicsTester.Skia.Gtk/GraphicsTester.Skia.Gtk.csproj: Language not supported
- src/Graphics/src/Graphics.Skia/SKPaintExtensions.cs: Evaluated as low risk
- src/Graphics/src/Graphics.Skia/SkiaCanvas.cs: Evaluated as low risk
- src/Graphics/src/Graphics.Skia/SkiaTextLayout.cs: Evaluated as low risk
- src/SingleProject/Resizetizer/src/SkiaSharpSvgTools.cs: Evaluated as low risk
- src/Graphics/src/Graphics.Skia/SkiaCanvasState.cs: Evaluated as low risk
Comments skipped due to low confidence (1)
src/SingleProject/Resizetizer/src/SkiaSharpRasterTools.cs:9
- [nitpick] The variable name 'img' could be more descriptive. Consider renaming it to 'skiaImage'.
SKImage img;
jfversluis
added
the
area-infrastructure
mattleibow
force-pushed
the
dev/update-skiasharp
branch
4 times, most recently
from
19bae90 to
f780dcc
Compare
|
I first want to merge tests in #26591 as we do not really have any skia graphics tests |
mattleibow
force-pushed
the
dev/update-skiasharp
branch
from
f780dcc to
8212546
Compare
|
Any news on this one 👀 ? |
mattleibow
force-pushed
the
dev/update-skiasharp
branch
from
fa6255d to
1de39ce
Compare
mattleibow
force-pushed
the
dev/update-skiasharp
branch
2 times, most recently
from
94bf9d9 to
0909368
Compare
mattleibow
force-pushed
the
dev/update-skiasharp
branch
from
0909368 to
8364ce2
Compare
mattleibow
added
area-drawing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates SkiaSharp to the latest stable version.
The code is mostly the same, however there are some obsolete things that we may have to use for now as doing it correctly will have breaking changes in the
Microsoft.Maui.Graphics.SkiaNuGet API.The change is the fact that in SkiaSharp v2.x, there was just a single
SKPaintobject that was used for paint/color/appearance AND font/text rendering. In the new SkiaSharp v3.x, this has been split intoSKPaintandSKFontobjects. Unfortunately, these types leaked out of a few MAUI types and thus changing it would force us to now expose a newSKFontargument in methods and return types of properties/methods.This may be acceptable though since these types are semi-implementation details and typically are not used directly, but are used via the abstract types.
Fixes #26099