Avoid double evaluation of all ProjectReferences #1276

rainersigwald · 2016-10-27T22:58:52Z

As of #1018, the ResolveProjectReferences flow (which is executed during solution load in VS and is therefore very perf-sensitive) is two-phase:

Run _GetProjectReferenceTargetFrameworkProperties to ask the reference "What TFM of yours should I build to match my current TFM?"
Run ResolveProjectReferences to ask the reference "What is your primary output for this TFM?"

Those evaluations have different sets of global properties (the first sets ReferringTargetFramework and the latter sets SetTargetFramework), so they must be evaluated separately. Neither called target takes very long, but the evaluation is not cheap. This means that time to ResolveProjectReferences has roughly doubled in cost for all projects.

Cost of crosstargeting should be on a pay-for-play basis as much as possible. Existing csproj -> existing csproj (ditto vcxproj) shouldn't be slowed down by this.

/cc @nguerrera

The text was updated successfully, but these errors were encountered:

Targeted mitigation for dotnet#1276. VC++ noticed a dramatic regression in solution-load performance related to the time cost of ResolveProjectReferences. That affects all projects, but we can safely assume that a .vcxproj is NOT using cross-targeting, while it's impossible to detect from the outside whether a .csproj is. This commit avoids the regression for C++ projects by just not calling the MSBuild task again for .vcxproj references.

Targeted mitigation for #1276. VC++ noticed a dramatic regression in solution-load performance related to the time cost of ResolveProjectReferences. That affects all projects, but we can safely assume that a .vcxproj is NOT using cross-targeting, while it's impossible to detect from the outside whether a .csproj is. This commit avoids the regression for C++ projects by just not calling the MSBuild task again for .vcxproj references.

Sarabeth-Jaffe-Microsoft · 2016-11-11T22:37:13Z

@nguerrera Any progress on this? Thanks!

nguerrera · 2017-01-27T20:27:19Z

Update on this: I worked hard on the approach we white boarded and it's doable, but too risky of a change for RTW, I've gotten far enough to determine that it can be done without breaking changes (unless you consider not calling GetTargetFrameworkProperties when we don't have to breaking. I don't.) So we can fix this in an update.

Meanwhile #1621 includes some escape hatches to turn it off or just force a selection, so that can be used as a workaround for anyone hitting the perf issue until we arrive with the improved protocol in an update.

rainersigwald · 2017-01-27T20:49:33Z

Sounds great. I agree that that wouldn't be a breaking change.

davkean · 2017-02-27T11:38:11Z

Just to add some additional data here, looking at trying to reduce build times over on project system, and this one is floating to the top as our slowest targets:

    18445 ms  _GetProjectReferenceTargetFrameworkProperties 278 calls
    28138 ms  ResolveProjectReferences                  32 calls
    40642 ms  RebuildSolution                            1 calls
    40644 ms  Rebuild                                   36 calls
    300481 ms  CleanReferencedProjects                   32 calls

rainersigwald · 2017-02-27T15:24:57Z

Nick gave me his prototype branch; I'm planning to pick this up this week.

davkean · 2017-04-13T00:58:02Z

Not sure what you mean? On some up-to-date builds, _GetProjectReferenceTargetFrameworkProperties is 63% of the build time - is that expected?

davkean · 2017-04-13T01:00:47Z

Re-reading above, maybe i need a little more guidance I'm not really understanding your conclusion - or what we can do get build time down.

rainersigwald · 2017-04-20T20:42:10Z

@davkean can you point me toward a repro of that extreme percentage? I can walk through that specific case and make sure my reasoning still holds.

In general, my theory is that: evaluation is fast and GetTargetFrameworkProperties is also fast. Therefore, any time spent in _GetProjectReferenceTargetFrameworkProperties is time spent waiting for the node to be available to do the work, and not time spent doing the work itself. I expect that wait time to be similar to the wait time for the node that did the compilation work, so it comes out in the wash.

Before cross-targeting was implemented, a project had a single output that was queried in ResolveProjectReferences by either `GetTargetPath` (in single-project-build scenarios) or the default target (`Build`) in command line builds. A cross-targeting project doesn't have a single output--it has one for each of its `TargetFrameworks`. A ProjectReference, then, has to first figure out which output to ask for--the one that's the best fit for the current project. The initial implementation of this was simple: unconditionally call `GetTargetFrameworkProperties` on every ProjectReference, passing a `ReferringTargetFramework`. Then, if the project cross-targets, specify the resulting TF on future calls to the ProjectReference. If the project has a single TF, do not specify it to avoid building it once (from the solution build) and again (from a reference, explicitly specifying the one TF). Unfortunately, adding a global property for `ReferringTargetFramework` will result in a separate evaluation for the project. This means that almost _every_ project in a solution will be evaluated at least twice--once directly, with no special global properties, and once for each unique `ReferringTargetFramework` that refers to it. This can be particularly onerous for C++ projects (.vcxproj), where evaluation time is nontrivial and doubling it is noticeable. That was mitigated by special-casing vcxproj in dotnet#1278, but that is inelegant and doesn't address the root cause. This change alters the calling pattern for `ProjectReference`s. Instead of asking all references for the correct TF, it breaks the problem into multiple phases: * Ask all references whether they cross-target, and split into cross-targeting and non-cross-targeting lists. * Perform the `GetTargetFrameworkProperties` query only on projects that reported that they cross-targeted. * Update (in place) the existing `_MSBuildProjectReferenceExistent` item to pass or undefine the relevant properties based on whether the reference cross-targets (and what TF is the best match). Fixes dotnet#1276.

rainersigwald · 2017-08-04T20:59:16Z

Picking this up again. I'm setting a testbed up:

Building this Roslyn project (at that version), after having built the whole repo (to restore packages).

In a "design-time-like" way, meaning

msbuild /m:1 /v:m /clp:Summary /flp:v=m;PerformanceSummary /t:CollectResolvedSDKReferencesDesignTime;DebugSymbolsProjectOutputGroup;ResolveComReferencesDesignTime;ContentFilesProjectOutputGroup;DocumentationProjectOutputGroupDependencies;SGenFilesOutputGroup;ResolveProjectReferencesDesignTime;SourceFilesProjectOutputGroup;DebugSymbolsProjectOutputGroupDependencies;SatelliteDllsProjectOutputGroup;BuiltProjectOutputGroup;SGenFilesOutputGroupDependencies;ResolveAssemblyReferencesDesignTime;CollectSDKReferencesDesignTime;DocumentationProjectOutputGroup;PriFilesOutputGroup;BuiltProjectOutputGroupDependencies;SatelliteDllsProjectOutputGroupDependencies;SDKRedistOutputGroup "/p:SolutionFileName=Roslyn.sln;LangName=en-US;Configuration=Debug;LangID=1033;DesignTimeBuild=true;SolutionDir=S:\\roslyn\\;SolutionExt=.sln;BuildingInsideVisualStudio=true;DefineExplicitDefaults=true;Platform=AnyCPU;SolutionPath=S:\\roslyn\\Roslyn.sln;SolutionName=Roslyn;DevEnvDir=C:\\Program Files %28x86%29\\Microsoft Visual Studio\\Preview\\EntInt\\Common7\\IDE\\"

On my machine with VS 26730.0.d15rel, that takes Time Elapsed 00:00:08.69, of which

      516 ms  ResolveAssemblyReferences                  1 calls
     3449 ms  ResolveProjectReferences                   1 calls
     3732 ms  _GetProjectReferenceTargetFrameworkProperties  36 calls

The 36 references are each evaluated twice, with some projects with lots of globbed includes taking more than 500 ms total evaluation time.

rainersigwald · 2017-08-04T21:13:42Z

Resurrecting dotnet/sdk#993 and #1866 cuts the time dramatically, as hoped (Time Elapsed 00:00:05.21):

      164 ms  ReportAssetsLogMessages                    1 calls
      186 ms  ResolveProjectReferences                   1 calls
      206 ms  _GetProjectReferenceTargetFrameworkProperties   1 calls
      504 ms  ResolveAssemblyReferences                  1 calls
     3422 ms  _GetProjectReferencesThatNeedProperties    1 calls

target diffs in the private MSBuild folder

diff --git a/MSBuild/15.0/Bin/Microsoft.Common.CurrentVersion.targets b/MSBuild/15.0/Bin/Microsoft.Common.CurrentVersion.targets
index 531d63f..36fcd53 100644
--- a/MSBuild/15.0/Bin/Microsoft.Common.CurrentVersion.targets
+++ b/MSBuild/15.0/Bin/Microsoft.Common.CurrentVersion.targets
@@ -910,7 +910,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="BuildGenerateSources"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework);"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties);"
         Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != '' and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'"
         ContinueOnError="!$(BuildingProject)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -935,7 +935,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="BuildCompile"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != ''  and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'"
         ContinueOnError="!$(BuildingProject)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -960,7 +960,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="BuildLink"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'$(BuildPassReferences)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '@(_MSBuildProjectReferenceExistent)' != ''  and '%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true'"
         ContinueOnError="!$(BuildingProject)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -1511,33 +1511,18 @@ Copyright (C) Microsoft Corporation. All rights reserved.
 
   <!--
     ====================================================================================
-                                        _GetProjectReferenceTargetFrameworkProperties
+                                        _GetProjectReferencesThatNeedProperties
 
-    Builds the GetTargetFrameworkProperties target of all existent project references,
-    passing $(TargetFrameworkMoniker) as $(ReferringTargetFramework) and sets the
-    SetTargetFramework metadata of the project reference to the value that is returned.
+    Builds the ShouldQueryForProperties target of all existent project references,
+    removing any TargetFramework and RuntimeIdentifier properties that are set as
+    global properties in this project.
 
-    This allows a cross-targeting project to select how it should be configured to
-    build against the most appropriate target for the referring target framework.
+    This allows a cross-targeting project to indicate that it should be asked
+    for a compatible TargetFramework before building.
 
     ======================================================================================
   -->
-  <Target Name="_GetProjectReferenceTargetFrameworkProperties"
-          Outputs="%(_MSBuildProjectReferenceExistent.Identity)">
-    <!--
-      Honor SkipGetTargetFrameworkProperties=true metadata on project references
-      to mean that the project reference is known not to target multiple frameworks
-      and the mechanism here for selecting the best one can be skipped as an optimization.
-
-      We give this treatment to .vcxproj by default since no .vcxproj can target more
-      than one framework.
-   -->
-   <ItemGroup>
-      <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' == '' and '%(Extension)' == '.vcxproj'">
-        <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
-      </_MSBuildProjectReferenceExistent>
-   </ItemGroup>
-
+  <Target Name="_GetProjectReferencesThatNeedProperties">
     <!--
        Allow project references to specify which target framework properties to set and their values
        without consulting the referenced project. This has two use cases:
@@ -1547,15 +1532,58 @@ Copyright (C) Microsoft Corporation. All rights reserved.
           there is also a .NETFramework implementation.
 
        2. As an escape hatch for cases where the compatibility check performed by 
-          GetTargetFrameworkProperties is faulty.
+          GetDesiredProperties is faulty.
     -->
     <ItemGroup>
-      <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SetTargetFramework)' != ''">
+      <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SetDesiredProperties)' != ''">
         <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
       </_MSBuildProjectReferenceExistent>
     </ItemGroup>
 
     <!--
+      Honor SkipGetTargetFrameworkProperties=true metadata on project references
+      to mean that the project reference is known not to target multiple frameworks
+      and the mechanism here for selecting the best one can be skipped as an optimization.
+    -->
+    <MSBuild
+        Projects="@(_MSBuildProjectReferenceExistent)"
+        Targets="ShouldQueryForProperties"
+        BuildInParallel="$(BuildInParallel)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform)"
+        ContinueOnError="!$(BuildingProject)"
+        RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove);$(PropertiesToRemoveWhenQueryingForDesiredProperties)"
+        Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' != 'true'">
+
+      <Output TaskParameter="TargetOutputs" ItemName="_MSBuildProjectReferenceWithDesiredPropertiesResults" />
+    </MSBuild>
+
+    <ItemGroup>
+      <!-- Transform the list so that its Identity correlates with that of _MSBuildProjectReferenceExistent. -->
+      <_MSBuildProjectReferenceWithDesiredProperties Include="@(_MSBuildProjectReferenceWithDesiredPropertiesResults->'%(OriginalItemSpec)')" />
+
+      <!-- Update refs to remove any properties that the reference knows (without the referring TF) it doesn't want. -->
+      <_MSBuildProjectReferenceExistent Condition="'@(_MSBuildProjectReferenceWithDesiredProperties)' == '%(Identity)' and '@(_MSBuildProjectReferenceWithDesiredProperties->'%(QueryForProperties)')' == 'false'">
+        <UndefineProperties>@(_MSBuildProjectReferenceExistent->'%(UndefineProperties)');@(_MSBuildProjectReferenceWithDesiredProperties->'%(UndefineProperties)')</UndefineProperties>
+      </_MSBuildProjectReferenceExistent>
+    </ItemGroup>
+  </Target>
+
+  <!--
+    ====================================================================================
+                                        _GetProjectReferenceTargetFrameworkProperties
+
+    Builds the GetDesiredProperties target of all existent project references,
+    passing $(TargetFrameworkMoniker) as $(ReferringTargetFramework) and sets the
+    SetDesiredProperties metadata of the project reference to the value that is returned.
+
+    This allows a cross-targeting project to select how it should be configured to
+    build against the most appropriate target for the referring target framework.
+
+    ======================================================================================
+  -->
+  <Target Name="_GetProjectReferenceTargetFrameworkProperties"
+          DependsOnTargets="_GetProjectReferencesThatNeedProperties">
+    <!--
       Select the moniker to send to each project reference  if not already set. NugetTargetMoniker (NTM) is preferred by default over 
       TargetFrameworkMoniker (TFM) because it is required to disambiguate the UWP case where TFM is fixed at .NETCore,Version=v5.0 and 
       has floating NTM=UAP,Version=vX.Y.Z. However, in other cases (classic PCLs), NTM contains multiple values and that will cause the MSBuild
@@ -1567,53 +1595,62 @@ Copyright (C) Microsoft Corporation. All rights reserved.
     </PropertyGroup>
 
     <MSBuild
-        Projects="%(_MSBuildProjectReferenceExistent.Identity)"
-        Targets="GetTargetFrameworkProperties"
+        Projects="@(_MSBuildProjectReferenceWithDesiredProperties)"
+        Targets="GetDesiredProperties"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); ReferringTargetFramework=$(ReferringTargetFrameworkForProjectReferences)"
+        Properties="%(_MSBuildProjectReferenceWithDesiredProperties.SetConfiguration); %(_MSBuildProjectReferenceWithDesiredProperties.SetPlatform); ReferringTargetFramework=$(ReferringTargetFrameworkForProjectReferences)"
         ContinueOnError="!$(BuildingProject)"
-        RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove);TargetFramework;RuntimeIdentifier"
-        Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' != 'true'">
+        RemoveProperties="%(_MSBuildProjectReferenceWithDesiredProperties.GlobalPropertiesToRemove);$(PropertiesToRemoveWhenQueryingForDesiredProperties)"
+        Condition="'%(_MSBuildProjectReferenceWithDesiredProperties.SkipGetTargetFrameworkProperties)' != 'true' and '%(_MSBuildProjectReferenceWithDesiredProperties.QueryForProperties)' == 'true'">
 
-      <Output TaskParameter="TargetOutputs" PropertyName="_ProjectReferenceTargetFrameworkProperties" />
+      <Output TaskParameter="TargetOutputs" ItemName="_ProjectReferenceTargetFrameworkProperties" />
     </MSBuild>
 
     <ItemGroup>
-      <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.Identity)' == '%(Identity)' and '$(_ProjectReferenceTargetFrameworkProperties)' != ''">
-        <SetTargetFramework>$(_ProjectReferenceTargetFrameworkProperties)</SetTargetFramework>
+      <!-- Build an item that has Identity matching _MSBuildProjectReferenceExistent and metadata for properties to set. -->
+      <_ProjectReferencesWithTargetFrameworkProperties Include="@(_ProjectReferenceTargetFrameworkProperties->'%(OriginalItemSpec)')" />
 
-        <UndefineProperties Condition="$(_ProjectReferenceTargetFrameworkProperties.Contains(`ProjectHasSingleTargetFramework=true`))">%(_MSBuildProjectReferenceExistent.UndefineProperties);TargetFramework;ProjectHasSingleTargetFramework</UndefineProperties>
-        <!-- Unconditionally remove the property that was set as a marker to indicate that for this call we should remove TargetFramework -->
-        <UndefineProperties Condition="!$(_ProjectReferenceTargetFrameworkProperties.Contains(`ProjectHasSingleTargetFramework=true`))">%(_MSBuildProjectReferenceExistent.UndefineProperties);ProjectHasSingleTargetFramework</UndefineProperties>
+      <!-- Set the project's returned TargetFramework -->
+      <_MSBuildProjectReferenceExistent Condition="'@(_ProjectReferencesWithTargetFrameworkProperties)' == '%(Identity)' and '@(_ProjectReferencesWithTargetFrameworkProperties->'%(SetDesiredProperties)')' != ''">
+        <SetDesiredProperties>@(_ProjectReferencesWithTargetFrameworkProperties->'%(SetDesiredProperties)')</SetDesiredProperties>
       </_MSBuildProjectReferenceExistent>
-    </ItemGroup>
 
-    <ItemGroup>
-      <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.Identity)' == '%(Identity)' and '$(_ProjectReferenceTargetFrameworkProperties)' != ''">
-        <UndefineProperties Condition="$(_ProjectReferenceTargetFrameworkProperties.Contains(`ProjectIsRidAgnostic=true`))">%(_MSBuildProjectReferenceExistent.UndefineProperties);RuntimeIdentifier;ProjectIsRidAgnostic</UndefineProperties>
-        <!-- Unconditionally remove the property that was set as a marker to indicate that for this call we should remove RuntimeIdentifier -->
-        <UndefineProperties Condition="!$(_ProjectReferenceTargetFrameworkProperties.Contains(`ProjectIsRidAgnostic=true`))">%(_MSBuildProjectReferenceExistent.UndefineProperties);ProjectIsRidAgnostic</UndefineProperties>
+      <!-- Remove any properties that the reference didn't want. -->
+      <_MSBuildProjectReferenceExistent Condition="'@(_ProjectReferencesWithTargetFrameworkProperties)' == '%(Identity)' and '@(_ProjectReferencesWithTargetFrameworkProperties->'%(UndefineProperties)')' != ''">
+        <UndefineProperties>@(_MSBuildProjectReferenceExistent->'%(UndefineProperties)');@(_ProjectReferencesWithTargetFrameworkProperties->'%(UndefineProperties)')</UndefineProperties>
       </_MSBuildProjectReferenceExistent>
     </ItemGroup>
-
-    <PropertyGroup>
-      <_ProjectReferenceTargetFrameworkProperties />
-    </PropertyGroup>
   </Target>
 
   <!--
     ============================================================
-                                    GetTargetFrameworkProperties
+                                    GetDesiredProperties
 
     Overrridden by cross-targeting projects to return the set of
-    properties (in the form "key1=value1;...keyN=valueN") needed
-    to build it with the best target for the referring project's
-    target framework.
+    properties (in the metadatum SetDesiredProperties` in the
+    form "key1=value1;...keyN=valueN") needed to build against
+    the target framework that best matches the referring
+    project's target framework.
+
+    The referring project's $(TargetFrameworkMoniker) is passed
+    in as $(ReferringTargetFramework).
+  -->
+  <Target Name="GetDesiredProperties" />
+
+  <!--
+    ============================================================
+                                        ShouldQueryForProperties
+
+    Overrridden by cross-targeting projects to return an item
+    with QueryForProperties metadata that is a boolean set to
+    "true" if the project should have its GetDesiredProperties
+    target called with a ReferringTargetFramework.
 
-    The referring project's $(TargetFrameworkMoniker) is passed 
-    in as $(ReferringTargetFramework)
+    If the returned QueryForProperties is false, the project
+    will be built with the returned UndefineProperties metadata
+    removed from its global properties.
   -->
-  <Target Name="GetTargetFrameworkProperties" />
+  <Target Name="ShouldQueryForProperties" />
 
   <!--
     ============================================================
@@ -1626,8 +1663,8 @@ Copyright (C) Microsoft Corporation. All rights reserved.
 
         [OUT]
         @(ProjectReferenceWithConfiguration)   - Project references with apporpriate metadata
-        @(_MSBuildProjectReferenceExistent)    - Subset of @(ProjectReferenceWithConfiguration) that exist 
-                                                 with added SetTargetFramework metadata for cross-targeting
+        @(_MSBuildProjectReferenceExistent)    - Subset of @(ProjectReferenceWithConfiguration) that exist
+                                                 with added SetDesiredProperties metadata for cross-targeting
         @(_MSBuildProjectReferenceNonExistent) - Subset of  @(ProjectReferenceWithConfiguration) that do not exist
     ============================================================
   -->
@@ -1682,7 +1719,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="GetTargetPath"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and ('$(BuildingInsideVisualStudio)' == 'true' or '$(BuildProjectReferences)' != 'true') and '$(VisualStudioVersion)' != '10.0' and '@(_MSBuildProjectReferenceExistent)' != ''"
         ContinueOnError="!$(BuildingProject)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -1709,7 +1746,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="%(_MSBuildProjectReferenceExistent.Targets);GetTargetPath"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and ('$(BuildingInsideVisualStudio)' == 'true' or '$(BuildProjectReferences)' != 'true') and '$(VisualStudioVersion)' == '10.0' and '@(_MSBuildProjectReferenceExistent)' != ''"
         ContinueOnError="!$(BuildingProject)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -1726,7 +1763,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="%(_MSBuildProjectReferenceExistent.Targets)"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform);  %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform);  %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '$(BuildingInsideVisualStudio)' != 'true' and '$(BuildProjectReferences)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''"
         ContinueOnError="$(ContinueOnError)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -1743,7 +1780,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="GetNativeManifest"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'%(_MSBuildProjectReferenceExistent.BuildReference)' == 'true' and '@(ProjectReferenceWithConfiguration)' != '' and '$(BuildingProject)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''"
         ContinueOnError="$(ContinueOnError)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -2318,7 +2355,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
   <Target Name="GetReferenceTargetPlatformMonikers" DependsOnTargets="PrepareProjectReferences">
     <MSBuild
       Projects="@(_MSBuildProjectReferenceExistent)"
-      Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+      Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
       Targets="GetTargetPathWithTargetPlatformMoniker"
       BuildInParallel="$(BuildInParallel)"
       ContinueOnError="!$(BuildingProject)"
@@ -4301,7 +4338,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="GetCopyToOutputDirectoryItems"
         BuildInParallel="$(BuildInParallel)"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         Condition="'@(_MSBuildProjectReferenceExistent)' != '' and '$(_GetChildProjectCopyToOutputDirectoryItems)' == 'true' and '%(_MSBuildProjectReferenceExistent.Private)' != 'false' and '$(UseCommonOutputDirectory)' != 'true'"
         ContinueOnError="$(ContinueOnError)"
         RemoveProperties="%(_MSBuildProjectReferenceExistent.GlobalPropertiesToRemove)">
@@ -4864,7 +4901,7 @@ Copyright (C) Microsoft Corporation. All rights reserved.
     <MSBuild
         Projects="@(_MSBuildProjectReferenceExistent)"
         Targets="Clean"
-        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetTargetFramework)"
+        Properties="%(_MSBuildProjectReferenceExistent.SetConfiguration); %(_MSBuildProjectReferenceExistent.SetPlatform); %(_MSBuildProjectReferenceExistent.SetDesiredProperties)"
         BuildInParallel="$(BuildInParallel)"
         Condition="'$(BuildingInsideVisualStudio)' != 'true' and '$(BuildProjectReferences)' == 'true' and '@(_MSBuildProjectReferenceExistent)' != ''"
         ContinueOnError="$(ContinueOnError)"
diff --git a/MSBuild/15.0/Microsoft.Common.props b/MSBuild/15.0/Microsoft.Common.props
index b04ff5b..defd522 100644
--- a/MSBuild/15.0/Microsoft.Common.props
+++ b/MSBuild/15.0/Microsoft.Common.props
@@ -147,6 +147,10 @@ Copyright (C) Microsoft Corporation. All rights reserved.
     <WMSJSProjectDirectory Condition="'$(WMSJSProjectDirectory)' == ''">JavaScript</WMSJSProjectDirectory>
   </PropertyGroup>
 
+  <PropertyGroup>
+    <PropertiesToRemoveWhenQueryingForDesiredProperties Condition="'$(PropertiesToRemoveWhenQueryingForDesiredProperties)' == ''">TargetFramework;RuntimeIdentifier</PropertiesToRemoveWhenQueryingForDesiredProperties>
+  </PropertyGroup>
+
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.VisualStudioVersion.v*.Common.props" Condition="'$(VisualStudioVersion)' == ''" />
 
   <!-- 
diff --git a/MSBuild/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.Common.targets b/MSBuild/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.Common.targets
index 1cdc34e..fad922e 100644
--- a/MSBuild/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.Common.targets
+++ b/MSBuild/Sdks/Microsoft.NET.Sdk/build/Microsoft.NET.Sdk.Common.targets
@@ -28,54 +28,127 @@ Copyright (c) .NET Foundation. All rights reserved.
     <DefaultImplicitPackages>Microsoft.NETCore.App;NETStandard.Library</DefaultImplicitPackages>
   </PropertyGroup>
 
+  <!--
+     Some versions of Microsoft.NET.Test.Sdk.targets change the OutputType after we've set _IsExecutable and
+     HasRuntimeOutput default in Microsfot.NET.Sdk.BeforeCommon.targets. Refresh these value here for backwards
+     compatibilty with that.
+   -->
+  <PropertyGroup>
+    <_IsExecutable Condition="'$(OutputType)' == 'Exe' or '$(OutputType)'=='WinExe'">true</_IsExecutable>
+    <HasRuntimeOutput Condition="'$(_UsingDefaultForHasRuntimeOutput)' == 'true'">$(_IsExecutable)</HasRuntimeOutput>
+  </PropertyGroup>
+
+  <PropertyGroup Condition="'$(DotnetCliToolTargetFramework)' == '' And '$(BundledNETCoreAppTargetFrameworkVersion)' != ''">
+    <!-- Set the TFM used to restore .NET CLI tools to match the version of .NET Core bundled in the CLI -->
+    <DotnetCliToolTargetFramework>netcoreapp$(BundledNETCoreAppTargetFrameworkVersion)</DotnetCliToolTargetFramework>
+  </PropertyGroup>
 
   <UsingTask TaskName="GetNearestTargetFramework" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" />
   <UsingTask TaskName="NETSdkError" AssemblyFile="$(MicrosoftNETBuildTasksAssembly)" />
-  
+
+  <!--
+    ============================================================
+                                        ShouldQueryForProperties
+
+    Indicate whether this project cross-targets, so before
+    building it, a referring project must call
+    GetDesiredProperties to get the matching TargetFramework to
+    specify.
+
+    If this project only has a single TF and a single RID,
+    return UndefineProperties to allow the referring project
+    to build it directly without a subsequent query.
+  -->
+  <Target Name="ShouldQueryForProperties"
+          Returns="@(_ShouldQueryForPropertiesResult)">
+    <PropertyGroup>
+      <!-- indicate to caller that project is RID agnostic so that a global property RuntimeIdentifier value can be removed -->
+      <_IsRidAgnostic>false</_IsRidAgnostic>
+      <_IsRidAgnostic Condition=" '$(RuntimeIdentifier)' == '' and '$(RuntimeIdentifiers)' == '' ">true</_IsRidAgnostic>
+
+      <_DesiredRemovedProperties Condition="'$(_IsRidAgnostic)' == 'true'">$(_DesiredRemovedProperties);RuntimeIdentifier</_DesiredRemovedProperties>
+
+      <!-- A project can only have more than one output if the current global properties are such that the current build is a cross-targeting one. -->
+      <_HasSingleTargetFramework Condition="'$(IsCrossTargetingBuild)' != 'true'">true</_HasSingleTargetFramework>
+      <_HasSingleTargetFramework Condition="'$(_HasSingleTargetFramework)' == ''">false</_HasSingleTargetFramework>
+
+      <_DesiredRemovedProperties Condition="'$(_HasSingleTargetFramework)' == 'true'">$(_DesiredRemovedProperties);TargetFramework</_DesiredRemovedProperties>
+
+      <_ReferringProjectShouldCallGetDesiredProperties>true</_ReferringProjectShouldCallGetDesiredProperties>
+      <_ReferringProjectShouldCallGetDesiredProperties Condition="$(_HasSingleTargetFramework) and $(_IsRidAgnostic)">false</_ReferringProjectShouldCallGetDesiredProperties>
+    </PropertyGroup>
+
+    <ItemGroup>
+      <_ShouldQueryForPropertiesResult Include="$(MSBuildProjectFullPath)">
+        <QueryForProperties>$(_ReferringProjectShouldCallGetDesiredProperties)</QueryForProperties>
+        <UndefineProperties Condition="'$(_ReferringProjectShouldCallGetDesiredProperties)' == 'false'">$(_DesiredRemovedProperties)</UndefineProperties>
+      </_ShouldQueryForPropertiesResult>
+    </ItemGroup>
+  </Target>
+
   <!--
   ============================================================
-                              GetTargetFrameworkProperties
+                              GetDesiredProperties
 
-    Invoked by common targets to return the set of properties 
-    (in the form  "key1=value1;...keyN=valueN") needed to build 
-    against the target framework that best matches the referring
-    project's target framework.
+    Invoked by common targets to return the set of properties
+    (in the metadatum SetDesiredProperties` in the form
+    "key1=value1;...keyN=valueN") needed to build against the
+    target framework that best matches the referring project's
+    target framework.
 
-    The referring project's $(TargetFrameworkMoniker) is passed 
+    The referring project's $(TargetFrameworkMoniker) is passed
     in as $(ReferringTargetFramework).
-
-    This is in the common targets so that it will apply to both
-    cross-targeted and single-targeted projects.  It is run
-    for single-targeted projects so that an error will be
-    generated if the referenced project is not compatible
-    with the referencing project's target framework.
   ============================================================
    -->
-  <Target Name="GetTargetFrameworkProperties" Returns="TargetFramework=$(NearestTargetFramework);ProjectHasSingleTargetFramework=$(_HasSingleTargetFramework);ProjectIsRidAgnostic=$(_IsRidAgnostic)">
+  <Target Name="GetDesiredProperties"
+          DependsOnTargets="ShouldQueryForProperties"
+          Returns="@(_ProjectBuildInstructions)">
 
     <PropertyGroup>
-      <!-- indicate to caller that project is RID agnostic so that a global property RuntimeIdentifier value can be removed -->
-      <_IsRidAgnostic>false</_IsRidAgnostic>
-      <_IsRidAgnostic Condition=" '$(RuntimeIdentifier)' == '' and '$(RuntimeIdentifiers)' == '' ">true</_IsRidAgnostic>
-
       <!-- If a ReferringTargetFramework was not specified, and we only have one TargetFramework, then don't try to check compatibility -->
       <_SkipNearestTargetFrameworkResolution Condition="'$(TargetFramework)' != '' and '$(ReferringTargetFramework)' == ''">true</_SkipNearestTargetFrameworkResolution>
       <NearestTargetFramework Condition="'$(_SkipNearestTargetFrameworkResolution)' == 'true'">$(TargetFramework)</NearestTargetFramework>
 
-      <!-- A project can only have more than one output if the current global properties are such that the current build is a cross-targeting one. -->
-      <_HasSingleTargetFramework Condition="'$(IsCrossTargetingBuild)' != 'true'">true</_HasSingleTargetFramework>
-      <_HasSingleTargetFramework Condition="'$(_HasSingleTargetFramework)' == ''">false</_HasSingleTargetFramework>
+      <_PossibleTargetFrameworks Condition="'$(TargetFramework)' != ''">$(TargetFramework)</_PossibleTargetFrameworks>
+      <_PossibleTargetFrameworks Condition="'$(TargetFramework)' == ''">$(TargetFrameworks)</_PossibleTargetFrameworks>
+    </PropertyGroup>
+
+    <GetNearestTargetFramework ReferringTargetFramework="$(ReferringTargetFramework)"
+                               PossibleTargetFrameworks="$(_PossibleTargetFrameworks)"
+                               ProjectFilePath="$(MSBuildProjectFullPath)"
+                               Condition="'$(_SkipNearestTargetFrameworkResolution)' != 'true'">
+      <Output PropertyName="NearestTargetFramework" TaskParameter="NearestTargetFramework" />
+    </GetNearestTargetFramework>
+
+    <ItemGroup>
+      <_ProjectBuildInstructions Include="$(MSBuildProjectFullPath)">
+        <SetDesiredProperties>TargetFramework=$(NearestTargetFramework)</SetDesiredProperties>
+        <UndefineProperties>$(_DesiredRemovedProperties)</UndefineProperties>
+      </_ProjectBuildInstructions>
+    </ItemGroup>
+  </Target>
+
+  <!-- This target is a compat shim, allowing the SDK to continue to function with older common targets that haven't switched to GetDesiredProperties.
+
+       TODO: After the SDK has picked up an MSBuild with https://github.com/Microsoft/msbuild/pull/1866, it should be deleted. -->
+  <Target Name="GetTargetFrameworkProperties" Returns="TargetFramework=$(NearestTargetFramework);ProjectHasSingleTargetFramework=$(_HasSingleTargetFramework);ProjectIsRidAgnostic=$(_IsRidAgnostic)"
+          DependsOnTargets="ShouldQueryForProperties">
+
+    <PropertyGroup>
+      <!-- If a ReferringTargetFramework was not specified, and we only have one TargetFramework, then don't try to check compatibility -->
+      <_SkipNearestTargetFrameworkResolution Condition="'$(TargetFramework)' != '' and '$(ReferringTargetFramework)' == ''">true</_SkipNearestTargetFrameworkResolution>
+      <NearestTargetFramework Condition="'$(_SkipNearestTargetFrameworkResolution)' == 'true'">$(TargetFramework)</NearestTargetFramework>
 
       <_PossibleTargetFrameworks Condition="'$(TargetFramework)' != ''">$(TargetFramework)</_PossibleTargetFrameworks>
       <_PossibleTargetFrameworks Condition="'$(TargetFramework)' == ''">$(TargetFrameworks)</_PossibleTargetFrameworks>
     </PropertyGroup>
 
-    <GetNearestTargetFramework ReferringTargetFramework="$(ReferringTargetFramework)" 
+    <GetNearestTargetFramework ReferringTargetFramework="$(ReferringTargetFramework)"
                                PossibleTargetFrameworks="$(_PossibleTargetFrameworks)"
                                ProjectFilePath="$(MSBuildProjectFullPath)"
                                Condition="'$(_SkipNearestTargetFrameworkResolution)' != 'true'">
       <Output PropertyName="NearestTargetFramework" TaskParameter="NearestTargetFramework" />
     </GetNearestTargetFramework>
   </Target>
-  
+
 </Project>

rainersigwald · 2017-08-24T20:24:03Z

I wrote up some detailed notes about the problem and options for solving it: https://gist.github.com/rainersigwald/fdf2be017223bf90850abf06ffa32169.

I talked to @nguerrera @davkean and @terrajobst about it a while ago and settled on the “Query for TFs; Choose in Consumer” approach as the option that looked the best. In particular, the improved error messages available from consumption-side TF selection are a big win.

Going down that road requires

Formalizing the multitargeted build into core MSBuild (it already is since crosstargeting.targets is in our repo and the existing ask-project-what-TF-to-build code is in common.targets).
Elevating the concept of TF compatibility to core MSBuild.
Changing the ProjectReference protocol to support the get-TFs target.

Formalizing multitargeting

Right now multitargeting is defined in MSBuild (crosstargeting.targets and the existing ask-project-what-TF-to-build code is in common.targets), and in the SDK.

Since any project type can reference a multitargeted project, we should just admit that it's a core MSBuild concept now. That means taking ownership of the definitions of multitargetable dimensions (currently that's just TargetFrameworks).

I don't think anything really has to change for this, just mindset.

Elevating TargetFramework compatibility

Deciding what TF from a list is most compatible with the a given TF is currently handled by NuGet.Frameworks, which is an optional add-in to MSBuild. It’s delivered in the SDK (that's how the current give-me-your-TF-properties code works) but isn’t available in some MSBuild scenarios.

Ideally, the compat matrix would be represented as data, and we could query it with a Framework method. At the moment, that doesn't appear likely to happen.

I propose that we add a reference to NuGet.Frameworks from Microsoft.Build.Tasks.Core.dll, and add a new target to perform the select-best-match-for-reference-or-error functionality. This is conceptually similar to the existing AssignProjectConfiguration, which considers solution configurations.

I've prototyped that in #2472. It does not include nice error messages yet.

Changing the ProjectReference protocol

This is tricky because it is necessarily a breaking change . . . but only for projects that manually implement the ProjectReference protocol and don't include common.targets.

If that’s too breaking for a minor release of VS, we could add an an engine feature (#2471) to avoid failing on ProjectReferences to projects that don't have a GetTargetFrameworks.

I have prototyped the change to the protocol in a way that's backward-compatible (as long as you import common.targets/crosstargeting.targets) in #2472.

Getting rid of double evaluation for multitargeted projects

This isn't possible in general, because with no knowlege of a project we can't know whether it multitargets or what TF to request, so we have to evaluate it in some context to figure out the right context to evaluate it in for real.

BUT! The list of supported TargetFrameworks shouldn’t change between the inner and outer builds. That means that we could

Query the supported TargetFrameworks for each reference.
Select the right one.
Persist that information in the current project's obj directory.
Resolve the reference with the right TF properties.

When resolving P's references with a cache:

Ask M and S what TFs they support, using the cached properties. [Evaluates M(TF=x) and S()]
Determine the best match TF for M, and that S's only TF is fine.
Annotate the reference for M in P with the desired target metadata.
Get the output for the given TF from M and S. [no new evaluations]

This allows us to maintain correctness if the TFs supported by a reference change (we still ask what it supports) but save an evaluation in the (common) case that the best-match TF is the same as it was last build.

Add GetReferenceNearestTargetFrameworkTask Related: dotnet/msbuild#1276

davkean · 2017-10-11T21:23:32Z

This was merged in: #2595.

rainersigwald added the Priority 0 label Oct 27, 2016

rainersigwald mentioned this issue Oct 27, 2016

Avoid x-targeting perf impact on vcxproj #1278

Merged

rainersigwald added this to the Visual Studio 15 RTM milestone Oct 28, 2016

rainersigwald mentioned this issue Oct 28, 2016

Cross-targeting dispatch to inner builds should be parallelized #1064

Closed

Sarabeth-Jaffe-Microsoft added the needs-design Requires discussion with the dev team before attempting a fix. label Nov 4, 2016

Sarabeth-Jaffe-Microsoft modified the milestones: MSBuild 15.1 RC.3, Visual Studio 15 RTM Dec 2, 2016

Sarabeth-Jaffe-Microsoft assigned nguerrera Dec 9, 2016

saul mentioned this issue Jan 2, 2017

_GetProjectReferenceTargetFrameworkProperties is extremely slow for F# projects #1510

Closed

rainersigwald modified the milestones: Visual Studio 15 RTM, MSBuild 15.1 RC.3 Jan 12, 2017

rainersigwald added regression performance .NET Core labels Jan 17, 2017

rainersigwald modified the milestones: Visual Studio 15 RTW, MSBuild 15 Update Jan 25, 2017

rainersigwald mentioned this issue Jan 31, 2017

Multi-proc build of a .sln file is 'The process cannot access the file because it is being used by another process.' dotnet/sdk#739

Closed

Sarabeth-Jaffe-Microsoft assigned rainersigwald Feb 10, 2017

rainersigwald mentioned this issue Apr 13, 2017

Future of incompatible-TF checks dotnet/sdk#1122

Closed

AndyGerlicher modified the milestones: MSBuild 15.3, After 15 May 2, 2017

cwe1ss mentioned this issue Jun 21, 2017

Topic: State of tooling dotnet/corefx-standup#7

Closed

rainersigwald modified the milestones: MSBuild 15 "foundation update" 2, After 15 Jun 22, 2017

rainersigwald marked this as a duplicate of #2309 Jul 17, 2017

rainersigwald mentioned this issue Jul 17, 2017

Consider making _GetProjectReferenceTargetFrameworkProperties target incremental #2309

Closed

rainersigwald mentioned this issue Aug 3, 2017

Target "BuiltProjectOutputGroup" does not exist when using <TargetFrameworks> dotnet/sdk#433

Open

davkean mentioned this issue Aug 16, 2017

[Tracking] Overhead of SDK build targets is too high for design-time builds dotnet/sdk#1496

Closed

This was referenced Aug 18, 2017

Perform nearest-TFM query in parallel #1785

Closed

Get TargetFrameworks for ProjectReferences in parallel #2458

Closed

panopticoncentral mentioned this issue Oct 6, 2017

Add AssignReferenceProperties task for MSBuild NuGet/NuGet.Client#1737

Merged

emgarten pushed a commit to NuGet/NuGet.Client that referenced this issue Oct 11, 2017

Add AssignReferenceProperties task for MSBuild (#1737)

dda0205

Add GetReferenceNearestTargetFrameworkTask Related: dotnet/msbuild#1276

davkean closed this as completed Oct 11, 2017

dsplaisted mentioned this issue Aug 6, 2019

Razor Static Web Assets feature is regressing build perf for large solutions dotnet/aspnetcore#12933

Closed

AR-May added the triaged label Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid double evaluation of all ProjectReferences #1276

Avoid double evaluation of all ProjectReferences #1276

rainersigwald commented Oct 27, 2016

Sarabeth-Jaffe-Microsoft commented Nov 11, 2016

nguerrera commented Jan 27, 2017

rainersigwald commented Jan 27, 2017

davkean commented Feb 27, 2017

rainersigwald commented Feb 27, 2017

davkean commented Apr 13, 2017 •

edited

Loading

davkean commented Apr 13, 2017

rainersigwald commented Apr 20, 2017

rainersigwald commented Aug 4, 2017

rainersigwald commented Aug 4, 2017

rainersigwald commented Aug 24, 2017

davkean commented Oct 11, 2017

Avoid double evaluation of all ProjectReferences #1276

Avoid double evaluation of all ProjectReferences #1276

Comments

rainersigwald commented Oct 27, 2016

Sarabeth-Jaffe-Microsoft commented Nov 11, 2016

nguerrera commented Jan 27, 2017

rainersigwald commented Jan 27, 2017

davkean commented Feb 27, 2017

rainersigwald commented Feb 27, 2017

davkean commented Apr 13, 2017 • edited Loading

davkean commented Apr 13, 2017

rainersigwald commented Apr 20, 2017

rainersigwald commented Aug 4, 2017

rainersigwald commented Aug 4, 2017

rainersigwald commented Aug 24, 2017

Formalizing multitargeting

Elevating TargetFramework compatibility

Changing the ProjectReference protocol

Getting rid of double evaluation for multitargeted projects

davkean commented Oct 11, 2017

davkean commented Apr 13, 2017 •

edited

Loading