Improve P2P handling for cross-targeting #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Deal with UWP case where NugetTargetMoniker is needed instead of TargetFrameworkMoniker 2. Provide mechanism to override the moniker that is passed to reference 3. Provide mechanism to pick any target framework of reference 4. Provide mechanism to skip the best TFM computation for known single-targeting case
| than one framework. | ||
| --> | ||
| <ItemGroup> | ||
| <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' == '' and '%(Extension)' == '.vcxproj'"> |
There was a problem hiding this comment.
Should this be or vcxproj? (instead of and)
There was a problem hiding this comment.
Makes sense to be able to opt into the double-eval even for a vcxproj if you really want to.
There was a problem hiding this comment.
Yes. Intentional.
There was a problem hiding this comment.
Read that wrong. Read that as explicit skip and vcxproj.
rainersigwald
approved these changes
Jan 27, 2017
| than one framework. | ||
| --> | ||
| <ItemGroup> | ||
| <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' == '' and '%(Extension)' == '.vcxproj'"> |
There was a problem hiding this comment.
Makes sense to be able to opt into the double-eval even for a vcxproj if you really want to.
AndyGerlicher
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndyGerlicher @rainersigwald
Customer scenario
Primary:
Referencing an SDK/CPS-based project from UWP project would behave incorrectly (pick wrong TFM of reference) or fail with incorrect incompatibility error.
Also:
Bugs this fixes:
#1474
#1390
dotnet/sdk#707
dotnet/project-system#477
Risk
Low.
Performance impact
Negligible.
Is this a regression from a previous update?
No.
Root cause analysis:
We missed the special cases around monikers for UWP.
How was the bug found?
Customer reported