Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring some of the Roslyn OOP build tasks over here #10106

Closed
davidwengier opened this issue Mar 15, 2024 · 0 comments · Fixed by #10179
Closed

Bring some of the Roslyn OOP build tasks over here #10106

davidwengier opened this issue Mar 15, 2024 · 0 comments · Fixed by #10179
Assignees
@davidwengier
Labels
tech-debt
Milestone
17.11 P1

Comments

@davidwengier
Copy link
Contributor

Whenever we add a new OOP service we have to add it to our vsix manifest, and 8 different json files, and a project file, and to attributes in our package, and if that doesn't all match then things won't work. Roslyn has various build tooling to automate some/all of this, and we should copy their homework.
This was referenced Mar 28, 2024
Merged
Merged
@phil-allen-msft phil-allen-msft added this to the 17.11 P1 milestone Mar 28, 2024
davidwengier added a commit that referenced this issue Mar 30, 2024
@davidwengier
Generate service hub plumbing files (#10179)
12bff57 
Fixes #10106
Part of #9519

The idea here is that when adding a new service, we only need to add an
entry to `Services.props`, rather that right now where we have to add 4
JSON files, 4 entries to the `csproj` file for those JSON files, 4
entries in the `vsixmanifest` for those JSON files, and 5 attributes in
the `RazorPackage.cs`, and god help you if you make a typo in any one of
those :)

Something to keep in mind while reviewing, this is MSBuild authoring,
and hence:

![NoIdeaNoClueGIF](https://github.com/dotnet/razor/assets/754264/f117cf1d-8e04-40e5-b4ea-aeafdcf9a65c)

Validation build:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2416980&view=results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwengier davidwengier

Labels
tech-debt
Projects
None yet
Milestone
17.11 P1
Development

Successfully merging a pull request may close this issue.

Generate service hub plumbing files davidwengier/razor
2 participants
@davidwengier @phil-allen-msft