Cohosting: Update Html virtual document from OOP #10175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Mar 28, 2024
There was a problem hiding this comment.
These changes look worse than they are. What I did was rearrange the entries so that each service is grouped together, and I noticed some paths used the ServiceHubCoreSubPath variable, and some hardcoded the path, so I fixed that too.
I'm going to prioritize #10106 and get rid of all of this though, because I lost about half a day trying to get this new service to work, only to discover than Roslyn strips the word "Service" off the end of a service, and assumes that the json files do the same thing.
davidwengier
commented
Mar 28, 2024
There was a problem hiding this comment.
As above, this is mainly just rearranging to group services together.
DustinCampbell
approved these changes
Mar 28, 2024
davidwengier
force-pushed
the
CohostHtmlDocuments
branch
from
fddabc0
to
3bfa78a
Compare
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9519
When cohosting is on, while processing a didOpen or didChange for a Razor document, we now call into OOP to get the generated Html document contents, and then update the virtual buffer.