Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoint integration tests don't assert anything #9161

Closed
davidwengier opened this issue Aug 24, 2023 · 0 comments · Fixed by #10811
Closed

Breakpoint integration tests don't assert anything #9161

davidwengier opened this issue Aug 24, 2023 · 0 comments · Fixed by #10811
Assignees
@jordi1215
Labels
test scenario
Milestone
17.12 Planning

Comments

@davidwengier
Copy link
Contributor

Currently two of the integration tests for breakpoint placement don't assert the correct action has been taken, and are thus useless. Additionally on my machine they don't actually take the correct action, so just adding in asserts would make them fail.
@ghost ghost added the untriaged label Aug 24, 2023
@phil-allen-msft phil-allen-msft added this to the 17.9 Planning milestone Sep 12, 2023
@ghost ghost removed the untriaged label Sep 12, 2023
@davidwengier davidwengier mentioned this issue Aug 29, 2024
Merged
davidwengier added a commit that referenced this issue Aug 29, 2024
@davidwengier
Fix setting breakpoints with self versioned documents (#10811)
e1f6fba 
Fixes an issue found in app building. Thanks @phil-allen-msft!

Also fixes #9161

To make reviewing easier:
* First commit is entirely mechanical cleanup, renames, etc. and can be
skipped.
* Second commit is the fix.
* Third commit is tests.
* Fourth commit is updating more tests because these days when you ask
VS to build things it doesn't build all of it and I need to get into the
habit of doing a command line build before pushing

Because of the type and file renames, looking at the PR as a whole is
inadvised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordi1215 jordi1215

Labels
test scenario
Projects
None yet
Milestone
17.12 Planning
Development

Successfully merging a pull request may close this issue.

Fix setting breakpoints with self versioned documents dotnet/razor
3 participants
@davidwengier @jordi1215 @phil-allen-msft