Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting breakpoints with self versioned documents #10811

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Aug 29, 2024

Fixes an issue found in app building. Thanks @phil-allen-msft!

Also fixes #9161

To make reviewing easier:

  • First commit is entirely mechanical cleanup, renames, etc. and can be skipped.
  • Second commit is the fix.
  • Third commit is tests.
  • Fourth commit is updating more tests because these days when you ask VS to build things it doesn't build all of it and I need to get into the habit of doing a command line build before pushing

Because of the type and file renames, looking at the PR as a whole is inadvised.

@davidwengier davidwengier requested a review from a team as a code owner August 29, 2024 02:30
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for cleaning up those abstract classes. I've been meaning to do that forever but haven't had the opportunity. 👍

@davidwengier davidwengier merged commit e1f6fba into main Aug 29, 2024
17 checks passed
@davidwengier davidwengier deleted the dev/dawengie/FixBreakpointVersioning branch August 29, 2024 20:33
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 29, 2024
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.12 P3 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakpoint integration tests don't assert anything
4 participants