Revert "Don't rebuild when doing rid-specific publishing, just publish (#9925)" #10014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#9925)" This reverts commit e77dc86.
davidwengier
approved these changes
Mar 1, 2024
|
FYI @jkoritzinsky |
|
I'll take a look at this again tomorrow and see if I can figure out a good solution. We need something like this for the VMR. |
jkoritzinsky
added a commit
to jkoritzinsky/razor
that referenced
this pull request
Mar 1, 2024
…sh (dotnet#9925)" (dotnet#10014) This reverts commit c5c96a2.
mmitche
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Reapply "Don't rebuild when doing rid-specific publishing, just publish (#9925)" (#10014) This reverts commit c5c96a2. * Slim down the built rids for vertical builds and only reduce overbuilding on a vertical build (where we won't have the other AppHost RIDs anyway). Also re-enable building the language servers in VMR non-sourcebuild builds. * Fix bad copy-paste job * Just use the regular RuntimeIdentifier property as PublishRuntimeIdentifier doesn't seem like it wants to work nicely. * fix typo * Pass TargetRid differently * PR feedback and preserve existing properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e77dc86 which was causing arm64 mac images to incorrectly try to use the x64 runtime. Fixes AB1977917