Undo temporary 'using' keyword hack #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Feb 26, 2024
ryzngard
approved these changes
Feb 26, 2024
|
Inserted a new Razor build into this PR, which also includes dotnet/razor#10014 to fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1977817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing temporary hack to add "using" keyword to completion since we have a better change to add it in both VS and VSCode (see dotnet/razor#9982).
For the most part it's an undo of prior PR #6441, but keeping one minor change from there that adjust completion item kind which is off by one with VS, this one
https://github.com/dotnet/vscode-csharp/blob/7e16947e68cb7a70177d3afba1d4e5116574259b/src/razor/src/completion/razorCompletionItemProvider.ts#L91C1-L93C18
which seems like a good change to keep.