Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle :get/:set in EditorRequired checking #10628

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Handle :get/:set in EditorRequired checking #10628

merged 3 commits into from
Jul 17, 2024

Conversation

jjonescz
Copy link
Member

Fixes #10553.

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Jul 16, 2024
@jjonescz jjonescz marked this pull request as ready for review July 16, 2024 11:54
@jjonescz jjonescz requested review from a team as code owners July 16, 2024 11:55
@jjonescz jjonescz merged commit c0b9aa2 into dotnet:main Jul 17, 2024
12 checks passed
@jjonescz jjonescz deleted the 10553-EditorRequired-bindGetSet branch July 17, 2024 08:06
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 17, 2024
This was referenced Jul 18, 2024
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 2, 2024
Closed
@Bouke
Copy link

Bouke commented Oct 17, 2024

Does this also handle first scenario reported in #10553, with @bind-Value?

@jjonescz
Copy link
Member Author

jjonescz commented Oct 17, 2024 •
edited
Loading

Does this also handle first scenario reported in #10553, with @bind-Value?

@bind-Value should have been already fixed by #8337.

But I just noticed that in the bug report EditorRequired is applied also to ValueChanged property - that looks like a variant not handled by either PR. I will investigate that.

@jjonescz
Copy link
Member Author

@Bouke thanks for bringing an attention to this; I'm fixing the mentioned cases in #11043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@DustinCampbell DustinCampbell DustinCampbell approved these changes

Assignees
No one assigned
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Milestone
17.12 Preview 1
Development

Successfully merging this pull request may close these issues.

RZ2012: False positive for different Blazor binding syntaxes
5 participants
@jjonescz @Bouke @DustinCampbell @333fred @RikkiGibson