Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle EditorRequired *Changed/*Expression parameters #11043

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 18, 2024

Fixes part of #10553 missed previously - when the ValueChanged or ValueExpression property is [EditorRequired].

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Oct 18, 2024
@jjonescz jjonescz marked this pull request as ready for review October 18, 2024 14:25
@jjonescz jjonescz requested a review from a team as a code owner October 18, 2024 14:25
@Bouke
Copy link

Bouke commented Oct 19, 2024

Thank you for looking into this. Could/should this now also cover ValueExpression when that is marked [EditorRequired]?

@jjonescz
Copy link
Member Author

jjonescz commented Oct 21, 2024

Could/should this now also cover ValueExpression when that is marked [EditorRequired]?

Yes, I forgot about that one, thanks!

@jjonescz jjonescz changed the title Handle EditorRequired *Changed parameters Handle EditorRequired *Changed/*Expression parameters Oct 21, 2024
@jjonescz jjonescz merged commit 8f7803e into dotnet:main Oct 22, 2024
12 checks passed
@jjonescz jjonescz deleted the 10553-EditorRequired-EventCallback branch October 22, 2024 08:02
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 22, 2024
333fred added a commit to 333fred/razor that referenced this pull request Oct 23, 2024
* upstream/main: (290 commits)
  Add breaking changes document (dotnet#11064)
  Do not extract component into code block (dotnet#11069)
  Fix invalid setttings json (dotnet#11062)
  update MicrosoftSourceBuildIntermediatearcadePackageVersion
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566512
  Update source-build team references (dotnet#11032)
  Handle EditorRequired *Changed/*Expression parameters (dotnet#11043)
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213
  Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2566213
  Avoid ambiguous `object` reference in generic component recovery (dotnet#11053)
  Move culture info check (dotnet#11057)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241015.1
  Fix code actions integration tests
  Add option for format on paste (dotnet#11039)
  Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs
  Fix merge to 17.12 version
  Update src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/Language/Components/ComponentDocumentClassifierPass.cs
  Ensure model directives are mapped at runtime (dotnet#11007)
  Fix @inherits mapping for fuse (dotnet#10985)
  ...
@phil-allen-msft phil-allen-msft modified the milestones: Next, 17.13 P1 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants