Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request duration logging #11198

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Nov 12, 2024

When first introduced there was an error in assumption of how histogram telemetry worked. This fixes this by correctly reporting a unique histogram even per lsp method name rather than the first one that comes in (which, as it turns out, was always initialize)

Also cleaned up the wording so it was a little easier to understand.

@ryzngard ryzngard requested a review from a team as a code owner November 12, 2024 04:47
@ryzngard
Copy link
Contributor Author

I'm wondering if we can remove this complexity altogether. I don't currently see a need to separate out the pools. @ToddGrun @dibarbet is there something I'm missing here? It looks like each https://github.com/ToddGrun/roslyn/blob/2cd8f0b6930a69f973454ecb8daf474c2d68d083/src/VisualStudio/Core/Def/Telemetry/Shared/AggregatingTelemetryLog.cs#L20 contains a set of telemetry events to be reported by the same name but with different metrics. Is there a logical reason to separate that so there's multiple pools?

Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@ToddGrun
Copy link
Contributor

I'm wondering if we can remove this complexity altogether. I don't currently see a need to separate out the pools. @ToddGrun @dibarbet is there something I'm missing here? It looks like each https://github.com/ToddGrun/roslyn/blob/2cd8f0b6930a69f973454ecb8daf474c2d68d083/src/VisualStudio/Core/Def/Telemetry/Shared/AggregatingTelemetryLog.cs#L20 contains a set of telemetry events to be reported by the same name but with different metrics. Is there a logical reason to separate that so there's multiple pools?

Not sure if you saw, but david did some cleanup about a month ago including the file you are referencing in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants