Report LSP loading telemetry #75402
Merged
Report LSP loading telemetry #75402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
lsp_project_telemetry
branch
from
a4ea1df
to
23bd767
Compare
JoeRobich
approved these changes
Oct 8, 2024
|
Had to add on a bunch to fix telemetry reporting. Mostly working in VSCode but converting to draft until I can test VS. Also the telemetry structure is changing for a few events, so I need to write test queries to verify its in a compatible shape |
dibarbet
force-pushed
the
lsp_project_telemetry
branch
from
b195efa
to
478a0e8
Compare
it always gets posted
dibarbet
force-pushed
the
lsp_project_telemetry
branch
from
478a0e8
to
47eac67
Compare
|
@JoeRobich @ToddGrun ready for review, I suggest commit at a time |
Open
3 tasks
ToddGrun
reviewed
Oct 11, 2024
ToddGrun
reviewed
Oct 11, 2024
ToddGrun
reviewed
Oct 11, 2024
...nguageServer/Microsoft.CodeAnalysis.LanguageServer/Telemetry/VSCodeRequestTelemetryLogger.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Oct 11, 2024
src/VisualStudio/Core/Def/Telemetry/Shared/AbstractAggregatingLog.cs
Outdated
Show resolved
Hide resolved
ToddGrun
reviewed
Oct 11, 2024
ToddGrun
reviewed
Oct 11, 2024
| var metricName = usedForkedSolution ? "ForkedCount" : "NonForkedCount"; | ||
| TelemetryLogging.LogAggregatedCounter(FunctionId.LSP_UsedForkedSolution, KeyValueLogMessage.Create(m => | ||
| { | ||
| m[TelemetryLogging.KeyName] = ServerTypeName + "." + metricName; |
There was a problem hiding this comment.
It is - see metricName on line 51
ToddGrun
reviewed
Oct 11, 2024
src/LanguageServer/Protocol/Handler/Telemetry/RequestTelemetryLogger.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #73224
Report telemetry events at various stages of the c# devkit project load process. Also report telemetry on how often we find documents in the correct workspace before and after project load.