Utilize C# Code Action Identifiers #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this up to give a general idea of the design. Note; this'll likely end up requiring VSCode changes as well. |
...src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CSharp/CSharpCodeActionProvider.cs
Outdated
Show resolved
Hide resolved
...rosoft.AspNetCore.Razor.LanguageServer/CodeActions/CSharp/DefaultCSharpCodeActionProvider.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CodeActionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Models/RazorCodeAction.cs
Outdated
Show resolved
Hide resolved
ryanbrandenburg
approved these changes
Mar 30, 2021
...rosoft.AspNetCore.Razor.LanguageServer/CodeActions/CSharp/DefaultCSharpCodeActionProvider.cs
Show resolved
Hide resolved
...rosoft.AspNetCore.Razor.LanguageServer/CodeActions/CSharp/DefaultCSharpCodeActionProvider.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Models/RazorCodeAction.cs
Outdated
Show resolved
Hide resolved
...pNetCore.Razor.LanguageServer.Test/CodeActions/CSharp/DefaultCSharpCodeActionProviderTest.cs
Outdated
Show resolved
Hide resolved
...Core.Razor.LanguageServer.Test/CodeActions/CSharp/TypeAccessibilityCodeActionProviderTest.cs
Outdated
Show resolved
Hide resolved
...ore.Razor.LanguageServer.Test/CodeActions/Razor/ExtractToCodeBehindCodeActionProviderTest.cs
Outdated
Show resolved
Hide resolved
TanayParikh
requested review from
allisonchou,
dougbu and
sharwell
as code owners
TanayParikh
commented
Mar 31, 2021
...ft.AspNetCore.Razor.LanguageServer/CodeActions/CSharp/TypeAccessibilityCodeActionProvider.cs
Outdated
Show resolved
Hide resolved
Removing these three tests. The start/end tests no longer make sense as we aren't enforcing diagnostics as we did previously. Handle_ValidDiagnostic_InvalidCodeAction_ReturnsEmpty also doesn't make sense any longer as we aren't enforcing the code action suffix must match the diagnostic.
NTaylorMullen
approved these changes
Mar 31, 2021
...Razor.LanguageServer/CodeActions/CSharp/ImplementInterfaceAbstractClassCodeActionProvider.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CodeActionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CodeActionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CodeActionEndpoint.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/CodeActionEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Models/RazorCodeAction.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/CodeActions/Models/RazorCodeAction.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageServer.cs
Outdated
Show resolved
Hide resolved
TanayParikh
commented
Mar 31, 2021
TanayParikh
commented
Mar 31, 2021
…3361) * Refactor Fully Qualify Code Action to Remove Diagnostics Dependency * Feedback * Update Versions.props * Update eng/Versions.props * Update TestLanguageServiceBroker.cs * PR Feedback * Disable Fully Qualify in Explicit Expressions * Tests
* Update Versions.props * Update Versions.props * Pin MicrosoftVisualStudioRpcContractsPackageVersion * Try older client impl version * Add back deprecated functions
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Ah looks like the LSP upgrade will be required. https://dev.azure.com/dnceng/public/_build/results?buildId=1068874&view=results Moving to cc/ @ToddGrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes: https://github.com/dotnet/aspnetcore/issues/25939