-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove script for building self-contained package #9891
Conversation
src/Razor/src/Microsoft.VisualStudio.DevKit.Razor/Microsoft.VisualStudio.DevKit.Razor.csproj
Outdated
Show resolved
Hide resolved
- RuntimeIdentifiers should not be needed for framework dependent - Specifically setting SelfContained to false - RuntimeIdentifierForPublish using RuntimeIdentifiers should not be used/needed anymore - Updated ProjectToPublish to happen once per project not N times (per RuntimeIdentifier)
Here's some notes from looking a bit further into our build scripts: In our publishing code I saw a reference to the comment below by @dsplaisted
Usage:
--- UPDATE After our offline discussion about platform specific vs agnostic, seems like we still need to be doing platform specific work so, as instructed I just removed the self contained bits and left everything else as-is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking we don't need to specify SelfContained=false
, but I have no problem being specific.
seems like we still need to be doing platform specific work
Just my 2c, but even if this wasn't true, I would still be very very strongly in favour of doing any work related to that in a separate PR. Changing multiple variables at the same time just makes testing and validation so much harder. Thankfully the point is moot :)
Summary of the changes
RuntimeIdentifiers
and self contained packaging related content in csprojUnsure if something else needs to be added,
Also unsure of how best to test the end to end on the extension side.
Related PRs: