Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.DirectoryServices dependency in test utilities #6515

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

Youssef1313
Copy link
Member

Fixes #6509

@stephentoub
Copy link
Member

I'm curious what DirectoryServices is used for here?

@Youssef1313
Copy link
Member Author

Youssef1313 commented Mar 6, 2023

.AddAssemblies(ImmutableArray.Create("PresentationFramework", "System.DirectoryServices", "System.Web", "System.Web.Extensions", "System.Xaml"))

I guess we can get rid of it and use AddPackages instead of AddAssemblies

@Youssef1313 Youssef1313 changed the title Update System.DirectoryServices to 6.0.1 Remove System.DirectoryServices dependency in test utilities Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #6515 (d674201) into main (c877c9a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head d674201 differs from pull request most recent head 203828f. Consider uploading reports for the commit 203828f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6515      +/-   ##
==========================================
+ Coverage   96.37%   96.41%   +0.04%     
==========================================
  Files        1390     1371      -19     
  Lines      324027   319164    -4863     
  Branches    10609    10270     -339     
==========================================
- Hits       312269   307724    -4545     
+ Misses       9218     8985     -233     
+ Partials     2540     2455      -85     

@buyaa-n
Copy link
Contributor

buyaa-n commented May 12, 2023

I'm curious what DirectoryServices is used for here?

Used in ReviewCodeForLdapInjectionVulnerabilities analyzer test

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavasani mavasani enabled auto-merge June 23, 2023 12:26
@mavasani mavasani merged commit 8405e7c into dotnet:main Jun 23, 2023
@sharwell sharwell mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CG alert for outdated version of System.DirectoryServices
5 participants