-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove System.DirectoryServices dependency in test utilities #6515
Conversation
I'm curious what DirectoryServices is used for here? |
I guess we can get rid of it and use AddPackages instead of AddAssemblies |
System.DirectoryServices
to 6.0.1
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6515 +/- ##
==========================================
+ Coverage 96.37% 96.41% +0.04%
==========================================
Files 1390 1371 -19
Lines 324027 319164 -4863
Branches 10609 10270 -339
==========================================
- Hits 312269 307724 -4545
+ Misses 9218 8985 -233
+ Partials 2540 2455 -85 |
Used in Line 32 in 5bfc7d5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6509