Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test sdk #6711

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Update test sdk #6711

merged 2 commits into from
Jun 23, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 23, 2023

@sharwell sharwell requested a review from a team as a code owner June 23, 2023 02:37
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #6711 (08bc1be) into main (8405e7c) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6711      +/-   ##
==========================================
- Coverage   96.37%   96.37%   -0.01%     
==========================================
  Files        1390     1390              
  Lines      324025   324039      +14     
  Branches    10609    10613       +4     
==========================================
+ Hits       312274   312284      +10     
- Misses       9211     9213       +2     
- Partials     2540     2542       +2     

@sharwell sharwell marked this pull request as draft June 23, 2023 17:25
auto-merge was automatically disabled June 23, 2023 17:25

Pull request was converted to draft

@sharwell sharwell marked this pull request as ready for review June 23, 2023 17:25
@sharwell sharwell merged commit f4cc17e into dotnet:main Jun 23, 2023
@sharwell sharwell deleted the update-test-sdk branch June 23, 2023 17:25
@sbomer
Copy link
Member

sbomer commented Jul 6, 2023

@sharwell do you have more context on why the test SDK started reporting suppressed warnings in code fix verifiers? Is it the list intended to include diagnostics suppressed via UnconditionalSuppressMessageAttribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants