Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Info tests fail when using new editor package versions #65840

Closed
dibarbet opened this issue Dec 7, 2022 · 3 comments · Fixed by #70523
Closed

Quick Info tests fail when using new editor package versions #65840

dibarbet opened this issue Dec 7, 2022 · 3 comments · Fixed by #70523

Comments

@dibarbet
Copy link
Member

dibarbet commented Dec 7, 2022

Found and disabled in #65795

at Roslyn.Utilities.Contract.Fail(String message, Int32 lineNumber) in /_/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs:line 154
   at Roslyn.Utilities.Contract.ThrowIfNull[T](T value, Int32 lineNumber) in /_/src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs:line 29
   at Microsoft.VisualStudio.Extensibility.Testing.EditorInProcess.<InvokeQuickInfoAsync>d__13.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/EditorInProcess.cs:line 272
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Roslyn.VisualStudio.IntegrationTests.VisualBasic.BasicQuickInfo.<International>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicQuickInfo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Note - these work fine in main. Only in -vs-deps with new editor package versions do these fail. Most likely related to the fact that the VS install on integration test machines is extremely old. Hopefully can re-enable with #65839

@dibarbet dibarbet self-assigned this Dec 7, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 7, 2022
@dibarbet dibarbet removed the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 7, 2022
@CyrusNajmabadi
Copy link
Member

@arkalyanms i know we've looked in the past about making it possible to get more recent versions of VS on our integration machines. But i think that work has stalled out. This is also important so we can adopt new editor APIs and have integration tests for them be updated at the same time. Right now that's often not possible.

@arunchndr
Copy link
Member

@arkalyanms i know we've looked in the past about making it possible to get more recent versions of VS on our integration machines. But i think that work has stalled out. This is also important so we can adopt new editor APIs and have integration tests for them be updated at the same time. Right now that's often not possible.

@dibarbet is this the case where we were seeing errors in integration test scouting queues which was preventing us from promoting to a newer VS version?

@dibarbet
Copy link
Member Author

dibarbet commented Dec 7, 2022

Yes. THis might be fixed after this PR goes in, but may not be fixed until we can upgrade to 17.5p2. Will test after
#65846

sharwell added a commit to sharwell/roslyn that referenced this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants