Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflicting key binding for integration tests #70523

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Oct 23, 2023

Closes #65840
Closes #70511

@sharwell sharwell requested a review from a team as a code owner October 23, 2023 19:29
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 23, 2023
@@ -28,6 +28,7 @@ public override async Task InitializeAsync()
await TestServices.SolutionExplorer.CloseSolutionAsync(HangMitigatingCancellationToken);
}

await TestServices.Workarounds.RemoveConflictingKeyBindingsAsync(HangMitigatingCancellationToken);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Would be good to restrict this with a version check

EnvDTE.Command command;
try
{
command = dte.Commands.Item("Edit.IntelliCode.APIUsageExamples");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Need to link to tracking bug

@sharwell sharwell merged commit 67b4ff7 into dotnet:main Nov 10, 2023
@ghost ghost added this to the Next milestone Nov 10, 2023
@sharwell sharwell deleted the fix-binding branch November 10, 2023 19:57
@RikkiGibson RikkiGibson modified the milestones: Next, 17.9 P2 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
6 participants