test pr plz ignore #5634
Closed
test pr plz ignore #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TryGoToDefinition accepted a containingTypeSymbol which was used to do some specific logic to see if third-party navigation is allowed. Move that logic to the AbstractGoToDefinitionService and just pass the result of the logic through.
Our INotificationService took a title and a message. In VS, the title and message were just concatenated together on consecutive lines and both displayed in the "message" portion of the message box. In other hosts, we used the title as the "real" message box title. Features were terribly inconsistent with how this was handled. Some features expected the VS behavior (and would have had clipped text in other hosts). Other features didn't expect the VS behavior, making ugly dialogs. The new behavior: the title is reserved for the title bar. This is ignored for the VS implementation, but should just be (if anything) the name of the feature complaining about something. All features who actually wanted the concatenation behavior are now doing so explicitly.
It can contain modifiers or other things, so it's not just a name.
This requires some updated handling of our INavigableItem interface. The Visual Studio implementation previously would only show the DisplayString if it had children, and would otherwise show file location and the source snippet. For implementations, the source snippet is somewhat useless: in the case of methods you just see the method signature a bunch of times. Thus, we wanted to show source location and a fully qualified name, something which wasn't expressible. The new interface now has DisplayString, which can be null if you want the string to be line from the source. Whether you want to show the file location is explicitly called out now too.
This behaves more or less exactly the same as IGoToDefinitionService.
… name right By placing it under the IDG_VS_EDIT_GOTO menu with CommandWellOnly, the command gets the name we want -- Edit.GoToImplementation -- but isn't visible. We then place it where we want it to be.
|
@rchande Still needed? |
|
Closing this as it's stale - feel free to reopen if you still need it. |
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Aug 16, 2023
… open documents. Fixes dotnet#5634 Implemented as per dotnet/vscode-csharp#5634 (comment) Currently, we only report local document diagnostics for open documents in the DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location projects in the WorkspacePullDiagnosticHandler. This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Aug 16, 2023
… open documents. Fixes dotnet#5634 Implemented as per dotnet/vscode-csharp#5634 (comment) Currently, we only report local document diagnostics for open documents in the DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location projects in the WorkspacePullDiagnosticHandler. This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Aug 16, 2023
… open documents. Fixes dotnet#5634 Implemented as per dotnet/vscode-csharp#5634 (comment) Currently, we only report local document diagnostics for open documents in the DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location projects in the WorkspacePullDiagnosticHandler. This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Aug 16, 2023
… open documents. Fixes dotnet#5634 Implemented as per dotnet/vscode-csharp#5634 (comment) Currently, we only report local document diagnostics for open documents in the DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location projects in the WorkspacePullDiagnosticHandler. This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.