Add support for reporting non-local LSP pull document diagnostics for open documents #69541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… open documents. Fixes dotnet#5634 Implemented as per dotnet/vscode-csharp#5634 (comment) Currently, we only report local document diagnostics for open documents in the DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location projects in the WorkspacePullDiagnosticHandler. This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.
dotnet-issue-labeler
bot
added
the
untriaged
dibarbet
reviewed
Aug 16, 2023
src/Features/LanguageServer/Protocol/Handler/Diagnostics/DocumentPullDiagnosticHandler.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/Diagnostics/DocumentPullDiagnosticHandler.cs
Outdated
Show resolved
Hide resolved
...r/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
...r/Protocol/Handler/Diagnostics/Public/PublicDocumentPullDiagnosticsHandler_IOnInitialized.cs
Outdated
Show resolved
Hide resolved
src/Features/LanguageServer/Protocol/Handler/PullHandlers/PreviousPullResult.cs
Outdated
Show resolved
Hide resolved
… one supported language.
mavasani
force-pushed
the
LspCompilationEnd
branch
from
0121aa0
to
3d2502c
Compare
3 tasks
dibarbet
approved these changes
Aug 19, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5634
Implemented as per dotnet/vscode-csharp#5634 (comment) - thanks @dibarbet, your suggestion works like a charm!
Currently, we only report local document diagnostics for open documents in
DocumentPullDiagnosticHandler. We report local and non-local diagnostics for closed documents, as well as no-location project diagnostics inWorkspacePullDiagnosticHandler.This change adds a new dynamically registered document diagnostic source in the public DocumentPullDiagnosticHandler with a new identifier to report non-local document diagnostics for open documents. I verified that after this change compilation end diagnostics are reported for open documents when FSA is enabled.