Workspace config options #59790
Merged
Workspace config options #59790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
force-pushed
the
WorkspaceConfigOptions
branch
2 times, most recently
from
c74eaff
to
ec407e2
Compare
tmat
force-pushed
the
WorkspaceConfigOptions
branch
from
d13c831
to
bd48e2d
Compare
|
There are RPS failures associated with this PR - https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/386878 (microsoft) |
tmat
force-pushed
the
WorkspaceConfigOptions
branch
from
bd48e2d
to
ad767ca
Compare
src/Features/LanguageServer/Protocol/Features/Options/WorkspaceConfigurationService.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/IWorkspaceConfigurationService.cs
Show resolved
Hide resolved
...orkspaces/Remote/ServiceHub/Services/ProcessTelemetry/RemoteWorkspaceConfigurationService.cs
Show resolved
Hide resolved
|
Overall this seems good. my significant concern is that we somehow regress something such that in OOP we end up not creating a storage-db and we don't catch it. Since we own the entire OOP story, it feels like we could have an assert that helps trap that from happening. |
Wouldn't tests catch that? Let me try to introduce this bug and see if a test fails: #60589 |
|
To call our remote services from our one needs to get RemoteHostClient first from ServiceHubRemoteHostClient.CreateAsync. This initializes the remote workspace options, so it is guaranteed that when we call the remote service the options are set. |
Looking at the traces I believe these failures are noise and not caused by this change. |
|
Confirmed by Calvin that the RPS issues are noise: |
CyrusNajmabadi
approved these changes
Apr 5, 2022
ghost
added this to the
333fred
added a commit
that referenced
this pull request
Apr 11, 2022
* Simplify * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Excluded Task.CompletionTask from completion list in async member declarations * Fix merge * Use existing assert * Use correct assert * Use isInferred: false when creating BoundArrayInitialization in CreateUTF8ByteRepresentation * Move few 'CodeFixProvider's to Analyzers layer * Fix * Fix * Remove ForegroundThreadAffinitizedObject usage * fix * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Remove ForegroundThreadAffinitizedObject usage * Revert bad changes * Fix errors and remove a hard CodeFixProvider back to Features * Update projitems * Move tests * Remove unused abstract property * Remove the single unused read of CodeFixCategory * Remove overrides in Analyzers * Remove overrides in Features * Fixed char recomendations test * Got rid of AsyncModifierName constants * Remove unnecessary `<Compile Remove` * Fixed tests for all other keywords * Cleaned up keyword tests * Move formatting analyzer to shared Analyzers layer * Move tests to shared Analyzers layer and more other fixes * Few more fixes * Fix bad changes * Fix bad changes * Fix bad changes * Remove IVTs of deleted test projects * Address review comment * Fix failing test * Cleanup unused resources in Features layer * Update Roslyn.Diagnostics.Analyzers and remove RS0005 suppressions * Move to SyntaxEditorBasedCodeFixProvider * Remove some 'MyCodeAction's * Remove more 'MyCodeAction's * One more that's not named MyCodeAction * Fix up changes between main and main-vs-deps * Colorize async as keyword in some cases * Few fixes * Added a bunch of tests, where async can never be a keyword, moved logic one level up * Fix typo * Note auto-default merged in feature status doc (#60564) * Update PublishData.json for 17.3 P1 (#60559) * Fix formatting * Added case with equals syntax, moved logic to a separate method * Add Rebuild badge to README (#60298) * Avoid using --blame-crash with CollectDumps This flag causes the test harness to attach ProcDump, which removes our ability to collect heap dumps on crash using Windows' built-in functionality. * Ensure current OOP calls for the same solution-checksum can share the same OOP solution computation * Update src/Workspaces/Remote/ServiceHub/Services/DocumentHighlights/RemoteDocumentHighlightsService.cs * Update src/Workspaces/Remote/ServiceHub/Services/SemanticClassification/RemoteSemanticClassificationService.cs * Revert name * Update tests * Fix * Add comment * Add comment * Update src/Workspaces/Remote/ServiceHub/Services/CodeLensReferences/RemoteCodeLensReferencesService.cs * fix grammar * Formatting * Revert * revert * Revert * Fix the Compiler VSIX extension so it works with CPS projects again This has been broken for quite some time. We were MEF importing a type that was no longer a MEF part, and referencing very old reference assemblies that needed to be updated as a part of responding to that original breaking change. * Make NotificationOption2 a serializable struct (#60573) * Update status for UTF8 literals and checked operators (#60587) * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1700800 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1700800 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1700800 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1700800 * Simplify * Simplify * Simplify * Simplify * [LSP] Modify semanticTokens `isFinalized` logic (#60484) * try/finally * Simplify * Move comment * Simplify * Doc * Doc * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1701033 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1701033 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1701033 * Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1701033 * Workspace config options (#59790) * REnames * Expand tuple * Rename parameter * Use deconstruction * Fix merge from main * Do not assert we are on the main thread in the constructor * Add support for unsafe local functions in IDE0062 code fix (#59297) * Track "numeric IntPtr" feature (#60579) * Address review comment * Add helpers * Remove unneeded IVTs * Simplify * Simplify * Pause computation of navbar items when a buffer is not visible * Rename * PR feedback part 1 * Change insertion branch * Update PublishData.json * PR feedback part 2 * lint * Implement handling of rename intent (#59410) * Implement handling of rename intent * Use documentId instead of URI * Move record definition up top * feedback * Address feedback * Remove unused files in CodeStyle layer * Remove unused resources in CodeStyle layer * Changed algorithm of detecting IAsyncEnumerable and IAsyncEnumerator, reverted some refactoring * Got rid of IsSystemRuntimeOrMscorlibAssembly method * Fix crash when combining reordered arguments with params array (#60622) * Fix string * Always use text edits in completion for correctness (#60466) * Filter down to task-like types when in an async context * Update providers * Cleanup * Revert * Revert * Revert * Simplify * Restore logic * Update test * Pull feature-specific APIs out of ISyntaxFacts * Extract out IBlockFacts out of ISyntaxFacts * Simplify * Instrument ReferenceCachingCS for flakiness (#60585) * Fix our INavigableSymbol to not root an entire solution-snapshot * Remove the TEmporaryWorkspace entirely from the RemoteWorkspace code. * Lint * Fixed adding a redundant blank line when suppressing with local attribute * [main] Update dependencies from dotnet/source-build-externals (#60359) [main] Update dependencies from dotnet/source-build-externals * Fix * Added more tests & refactoring * Clean up syntax context * Clean up syntax context * Clean up syntax context * Clean up syntax context * Simplify * Delay starting the work to scan for todo-items * move properties * Cleanup * Cleanup * Update tests * Fixup * Run continuation to dispose of cancellation token source (#60653) * Run continuation to dispose of cancellation token source * Remove cancellation token and execute synchronously * Update src/Features/LanguageServer/Protocol/Handler/RequestExecutionQueue.cs Co-authored-by: CyrusNajmabadi <[email protected]> Co-authored-by: CyrusNajmabadi <[email protected]> * Global indentation options - take 2 (#60565) * Revert "Revert "Global indentation options (#59679)" (#60199)" This reverts commit ab57ce8. * Move IFormattingInteractionService to Editor Features and add inferred indentation detection to its implementation. Move GetFormattingChangesOnTypedCharacterAsync, GetFormattingChangesOnPasteAsync to ISyntaxFormattingService - these do not depend on the editor. * Test fix * Update struct field definite assignment tests * Restore CodeStyle test projects * Lint * Fallout * Pass options to FixAllAsync, simplify CodeAction registration (#60665) * Trim unnessasary leading lines when removing usings (#60672) * Formatting and code generation options (#60127) * Remove duplicate package references (#60658) * Remove duplicate package references * Delete additional Tools.props * Update for definite assignment changes Co-authored-by: Cyrus Najmabadi <[email protected]> Co-authored-by: Joey Robichaud <[email protected]> Co-authored-by: CyrusNajmabadi <[email protected]> Co-authored-by: DoctorKrolic <[email protected]> Co-authored-by: David Barbet <[email protected]> Co-authored-by: Joey Robichaud <[email protected]> Co-authored-by: Youssef1313 <[email protected]> Co-authored-by: DoctorKrolic <[email protected]> Co-authored-by: Manish Vasani <[email protected]> Co-authored-by: Jason Malinowski <[email protected]> Co-authored-by: Rikki Gibson <[email protected]> Co-authored-by: Allison Chou <[email protected]> Co-authored-by: Sam Harwell <[email protected]> Co-authored-by: Tomáš Matoušek <[email protected]> Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com> Co-authored-by: Julien Couvreur <[email protected]> Co-authored-by: Gérald Barré <[email protected]> Co-authored-by: Jonathon Marolf <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Charles Stoner <[email protected]> Co-authored-by: Fredric Silberberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename ISyntaxTreeConfigurationService to IWorkspaceConfigurationService and consolidate all options that are set once for the process and control core workspace behaviors.