Preserve formatting when converting array-expressions to collection-expressions. #69278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
useCollectionExpression5
branch
from
bfc5393
to
1534a1a
Compare
akhera99
approved these changes
Jul 31, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work so that the collection-expression we produce is as close as possible to the user's original code as possible. Importantly, a major tenet of this is that we want the
[ ]braces of the collection expression to correspond to where the{ }braces were in the original expression if present.This PR is just for array expressions:
{ ... },new T[] { ... },new[] { ... }.This will also apply in future PRs that deal with converting collection initializers
new X() { ... }to collection expressions.