Add analyzer/fixer to update expressions like Array.Empty<T>() over to using the [] collection expression.
#69279
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -12,33 +12,30 @@ | |||
| using Microsoft.CodeAnalysis.LanguageService; | |||
| using Microsoft.CodeAnalysis.UseCollectionInitializer; | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.CSharp.UseCollectionInitializer | |||
| namespace Microsoft.CodeAnalysis.CSharp.UseCollectionInitializer; | |||
There was a problem hiding this comment.
review with whitespasce off.
| @@ -53,7 +54,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context) | |||
|
|
|||
| foreach (var diagnostic in diagnostics.OrderByDescending(d => d.Location.SourceSpan.Start)) | |||
| { | |||
| var expression = diagnostic.Location.FindNode(getInnermostNodeForTie: true, cancellationToken); | |||
| var expression = diagnostic.AdditionalLocations[0].FindNode(getInnermostNodeForTie: true, cancellationToken); | |||
There was a problem hiding this comment.
this was a bug before, but was not something you could generally notice as the location was the first token of these nodes and asking for the node would give you teh same thing. but htis is more correct/safer, so i updated.
| IsOnSingleLine(sourceText, initializer))); | ||
| } | ||
|
|
||
| bool ShouldReplaceExistingExpressionEntirely(ExpressionSyntax explicitOrImplicitArray, InitializerExpressionSyntax initializer) |
There was a problem hiding this comment.
this is from #69278
| @@ -243,7 +243,8 @@ class C | |||
| FixedCode = """ | |||
| class C | |||
| { | |||
| object[] i = [ | |||
| object[] i = | |||
There was a problem hiding this comment.
this is from #69278
| using Microsoft.CodeAnalysis.Testing; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.Analyzers.UnitTests.UseCollectionExpression; |
There was a problem hiding this comment.
these are the new tests.
CyrusNajmabadi
force-pushed
the
useCollectionExpression3
branch
from
01a4e2b to
1534a1a
Compare
|
@akhera99 ptal :) |
| @@ -88,14 +88,14 @@ private static void AnalyzeArrayInitializer(SyntaxNodeAnalysisContext context) | |||
| : initializer; | |||
|
|
|||
| if (!UseCollectionExpressionHelpers.CanReplaceWithCollectionExpression( | |||
| semanticModel, arrayCreationExpression, cancellationToken)) | |||
| semanticModel, arrayCreationExpression, skipVerificationForReplacedNode: false, cancellationToken)) | |||
There was a problem hiding this comment.
this is needed as the speculative system currently isn't ok with a node's kind changing this dramatically. specifically from a method invocation to another expression form. I wasn't comfortable mucking with the deep speculatrion logic, so easier to just not compare the bottommost nodes directly.
There was a problem hiding this comment.
😄I don't have any context about this, but choose to trust you here
ghost
added this to the 
Draft while waiting for #69219 to go in.