Add ExternalAccess.RazorCompiler.dll reference to C# language server
#70176
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Shouldn't this be shipped as part of Razor then? |
Roslyn's |
No. We want the version of the external access to match the shipped version of roslyn, not razor, as underlying API changes happen but we keep the EA layer stable. I'm sure @sharwell would also be happy to elaborate on the reasoning. |
ghost
added this to the 
Absolutely not. This package is version-locked to a single exact version of the compiler (no deviation is allowed in either direction), and therefore must ship with the compiler. |
| @@ -58,6 +58,9 @@ | |||
|
|
|||
| <!-- Dlls we don't directly reference but need to include to build the MEF composition --> | |||
| <ProjectReference Include="..\..\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Features.csproj" /> | |||
|
|
|||
| <!-- Not directly referenced but needed for Razor source generators --> | |||
| <ProjectReference Include="..\..\..\Tools\ExternalAccess\RazorCompiler\Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.csproj" /> | |||
There was a problem hiding this comment.
@allisonchou This needs ReferenceOutputAssembly="false" added for compile-time enforcement of the "not directly referenced" condition
There was a problem hiding this comment.
Got it, will add it in a follow up PR
Razor relies on Roslyn to ship this dll with the language server since they use it for source generators.