Add ReferenceOutputAssembly="false" to language server dlls we don't ship #70195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
sharwell
approved these changes
Sep 29, 2023
jasonmalinowski
approved these changes
Sep 30, 2023
...ageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj
Show resolved
Hide resolved
|
@jasonmalinowski thanks for the tip. I did a |
sharwell
reviewed
Oct 2, 2023
| @@ -57,7 +57,7 @@ | |||
| <ProjectReference Include="..\Protocol\Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj" /> | |||
|
|
|||
| <!-- Dlls we don't directly reference but need to include to build the MEF composition --> | |||
| <ProjectReference Include="..\..\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Features.csproj" ReferenceOutputAssembly="false" /> | |||
| <ProjectReference Include="..\..\CSharp\Portable\Microsoft.CodeAnalysis.CSharp.Features.csproj" /> | |||
There was a problem hiding this comment.
📝 If we omit ReferenceOutputAssembly="false", the comment needs to be updated. Currently there is a mismatch.
There was a problem hiding this comment.
I lean towards keeping the exclusion which allows us to make a conscious decision later if we think need to add references in code.
There was a problem hiding this comment.
I lean towards keeping the exclusion which allows us to make a conscious decision later if we think need to add references in code.
That's a good point - I've added that line back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR per Sam's comment in #70176 (comment):