Support UnscopedRef attribute on interface methods and properties #72171
Conversation
dotnet-issue-labeler
bot
added
the
untriaged
| } | ||
|
|
||
| // Receiver of an interface method could possibly be a structure. | ||
| // Let's treat it as scoped ref by ref parameter for the purpose of ref safety analysis. |
There was a problem hiding this comment.
| // Let's treat it as scoped ref by ref parameter for the purpose of ref safety analysis. | |
| // Let's treat it as scoped ref parameter for the purpose of ref safety analysis. | |
| ``` #WontFix |
There was a problem hiding this comment.
This isn't actually a typo. the value that we return is ScopedRef and the parameter is ref parameter
| @@ -2729,6 +2735,84 @@ private static ErrorCode GetStandardCallEscapeError(bool checkingReceiver) | |||
| { | |||
| return checkingReceiver ? ErrorCode.ERR_EscapeCall2 : ErrorCode.ERR_EscapeCall; | |||
| } | |||
|
|
|||
| #nullable enable | |||
There was a problem hiding this comment.
Consider nullable-enabling the trivial function above as well to make the #nullable enable range more contiguous. #Resolved
| { | ||
| get { return -1; } | ||
| } | ||
|
|
||
| public override ImmutableArray<CustomModifier> RefCustomModifiers | ||
| public sealed override ImmutableArray<CustomModifier> RefCustomModifiers | ||
| { | ||
| get { return ImmutableArray<CustomModifier>.Empty; } | ||
| } | ||
|
|
||
| // TODO: structs |
There was a problem hiding this comment.
I know this comment has been copied, but I don't understand what it means. Maybe it can be removed? #Resolved
| if (attributeData is SourceAttributeData { ApplicationSyntaxReference: { } applicationSyntaxReference } && | ||
| attributeData.IsTargetAttribute(AttributeDescription.UnscopedRefAttribute)) | ||
| { | ||
| MessageID.IDS_RefStructInterfaces.CheckFeatureAvailability(diagnostics, implementingSymbol.DeclaringCompilation, applicationSyntaxReference.GetLocation()); |
There was a problem hiding this comment.
Consider asserting we always get here (i.e., find the UnscopedRefAttribute). #Resolved
| } | ||
|
|
||
| [Fact] | ||
| public void UnscopedRefInInterface_Property_08() |
There was a problem hiding this comment.
Consider testing also indexers. #Resolved
There was a problem hiding this comment.
Consider testing also indexers.
While I can certainly clone property tests with indexers, I do not think the tests will have any immediate value, because, from the symbol model point of view indexers are properties, they do not have separate representation or handling.
| interface C : I | ||
| { | ||
| [UnscopedRef] | ||
| ref int I.M() |
There was a problem hiding this comment.
Do we have a similar test (interface derived from another interface) but where the method is not explictly implemented? #Resolved
There was a problem hiding this comment.
Do we have a similar test (interface derived from another interface) but where the method is not explictly implemented?
I am not sure what scenario you have in mind. Could you please elaborate? Implicit implementation is not a thing in interfaces.
There was a problem hiding this comment.
Never mind then, I haven't realized that.
|
@cston, @dotnet/roslyn-compiler For the second review |
Are there any changes here related to interfaces? #Resolved Refers to: src/Compilers/CSharp/Test/Emit2/Semantics/RefStructInterfacesTests.cs:3382 in 004452e. [](commit_id = 004452e, deletion_comment = False) |
Should this be Refers to: src/Compilers/CSharp/Test/Emit2/Semantics/RefStructInterfacesTests.cs:2765 in 004452e. [](commit_id = 004452e, deletion_comment = False) |
Refers to: src/Compilers/CSharp/Test/Emit2/Semantics/RefStructInterfacesTests.cs:3538 in 004452e. [](commit_id = 004452e, deletion_comment = False) |
It looks like I missed adjusting this test. Thanks. In reply to: 1959806502 Refers to: src/Compilers/CSharp/Test/Emit2/Semantics/RefStructInterfacesTests.cs:3382 in 004452e. [](commit_id = 004452e, deletion_comment = False) |
AlekseyTs
merged commit b18a065
into
dotnet:features/RefStructInterfaces
https://github.com/dotnet/csharplang/blob/main/proposals/ref-struct-interfaces.md#ref-struct-interfaces-1