Merge 'main' into RefStructInterfaces

.github/policies/resourceManagement.yml

@@ -0,0 +1,232 @@
+id: 
+name: GitOps.PullRequestIssueManagement
+description: GitOps.PullRequestIssueManagement primitive
+owner: 
+resource: repository
+disabled: false
+where: 
+configuration:
+  resourceManagementConfiguration:
+    scheduledSearches:
+    - description: Close "Need More Info" Issues
+      frequencies:
+      - hourly:
+          hour: 3
+      filters:
+      - isOpen
+      - isIssue
+      - hasLabel:
+          label: Need More Info
+      - noActivitySince:
+          days: 10
+      actions:
+      - closeIssue
+      - addReply:
+          reply: "Closing this issue as we've seen no reply to the request for more information. If you are able to get the requested information, please add it to the issue and we will retriage it. "
+    eventResponderTasks:
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - labelAdded:
+          label: auto-merge
+      - or:
+        - activitySenderHasPermission:
+            permission: Admin
+        - isActivitySender:
+            user: dotnet-bot
+            issueAuthor: False
+      then:
+      - approvePullRequest:
+          comment: Auto-approval
+      description: Auto-approve auto-merge PRs
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - isActivitySender:
+          user: dotnet-maestro[bot]
+          issueAuthor: False
+      - isAction:
+          action: Opened
+      - not:
+          bodyContains:
+            pattern: Updates sdk.version
+            isRegex: False
+      then:
+      - approvePullRequest:
+          comment: Auto-approve
+      description: Auto-approve maestro PRs
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - or:
+        - targetsBranch:
+            branch: main
+        - targetsBranch:
+            branch: main-vs-deps
+      - and:
+        - isAction:
+            action: Closed
+        - isMerged
+      then:
+      - addMilestone:
+          milestone: Next
+      description: Milestone tracking
+      triggerOnOwnActions: true
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - isActivitySender:
+          user: dotnet-bot
+          issueAuthor: False
+      - titleContains:
+          pattern: Localized file check-in
+          isRegex: False
+      - isAction:
+          action: Opened
+      then:
+      - addLabel:
+          label: auto-merge
+      description: Auto-approve OneLoc PRs
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Issue_Comment
+      - isIssue
+      - isOpen
+      - hasLabel:
+          label: Need More Info
+      then:
+      - addLabel:
+          label: untriaged
+      - removeLabel:
+          label: Need More Info
+      description: Remove "Need More Info" on comment
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - isAction:
+          action: Opened
+      - and:
+        - not:
+            activitySenderHasPermission:
+              permission: Admin
+        - not:
+            activitySenderHasPermission:
+              permission: Write
+        - not:
+            isActivitySender:
+              user: github-actions[bot]
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: dotnet-maestro[bot]
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: dotnet-maestro-bot[bot]
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: dotnet-maestro-bot
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: dotnet-maestro
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: github-actions
+              issueAuthor: False
+      then:
+      - addLabel:
+          label: Community
+      description: Label Community Pull Requests
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Pull_Request
+      - isPullRequest
+      - filesMatchPattern:
+          pattern: '[xX][aA][mM][lL]$'
+      - and:
+        - not:
+            hasLabel:
+              label: UX Review Requested
+        - not:
+            hasLabel:
+              label: UX Review Complete
+        - not:
+            hasLabel:
+              label: UX Review Not Required
+        - not:
+            hasLabel:
+              label: Needs UX Triage
+      - or:
+        - isAction:
+            action: Opened
+        - isAction:
+            action: Synchronize
+        - and:
+          - isAction:
+              action: Closed
+          - isMerged
+      - and:
+        - not:
+            isActivitySender:
+              user: dotnet-bot
+              issueAuthor: False
+        - not:
+            isActivitySender:
+              user: dotnet-maestro[bot]
+              issueAuthor: False
+      - not:
+          titleContains:
+            pattern: ^Merge .* to .*$
+            isRegex: True
+      then:
+      - addLabel:
+          label: Needs UX Triage
+      description: Add "Needs UX Triage" on PRs
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Pull_Request
+      - filesMatchPattern:
+          pattern: .*/PublicAPI\.(Shipped|Unshipped)\.txt
+      - not:
+          isActivitySender:
+            user: dotnet-bot
+            issueAuthor: False
+      - or:
+        - isAction:
+            action: Opened
+        - isAction:
+            action: Synchronize
+      - and:
+        - not:
+            hasLabel:
+              label: api-approved
+        - not:
+            hasLabel:
+              label: Needs API Review
+      then:
+      - addLabel:
+          label: Needs API Review
+      - addReply:
+          reply: This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.
+      description: Adds "Needs API Review" on PRs that touch public APIs
+      triggerOnOwnActions: false
+    - if:
+      - payloadType: Issues
+      - isIssue
+      - hasLabel:
+          label: vs-insertion
+      - titleContains:
+          pattern: '[Automated] PRs inserted in VS build'
+          isRegex: False
+      then:
+      - closeIssue
+      description: Close automatically generated PR tagger issues
+      triggerOnOwnActions: false
+onFailure: 
+onSuccess:

azure-pipelines.yml

@@ -385,34 +385,22 @@ stages:
     steps:
       - template: eng/pipelines/checkout-windows-task.yml
 
-      - task: PowerShell@2
+      - powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -restore -binaryLogName Restore.binlog 
         displayName: Restore
-        inputs:
-          pwsh: true
-          filePath: eng/build.ps1
-          arguments: -configuration Release -prepareMachine -ci -restore -binaryLogName Restore.binlog 
 
-      - task: PowerShell@2
+      - powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -build -pack -publish -sign -binaryLogName Build.binlog
         displayName: Build
-        inputs:
-          pwsh: true
-          filePath: eng/build.ps1
-          arguments: -configuration Release -prepareMachine -ci -build -pack -publish -sign -binaryLogName Build.binlog
 
       - script: $(Build.SourcesDirectory)\artifacts\bin\BuildBoss\Release\net472\BuildBoss.exe  -r "$(Build.SourcesDirectory)/" -c Release -p Roslyn.sln
         displayName: Validate Build Artifacts
 
-      - pwsh: |
-          ./eng/validate-rules-missing-documentation.ps1 -ci
+      - powershell: eng/validate-rules-missing-documentation.ps1 -ci
         displayName: Validate rules missing documentation
 
-      - pwsh: |
-          ./eng/generate-compiler-code.ps1 -test -configuration Release
+      - powershell: eng/generate-compiler-code.ps1 -test -configuration Release
         displayName: Generate Syntax Files
-        condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))
 
-      - pwsh: |
-          ./eng/validate-code-formatting.ps1 -ci -rootDirectory $(Build.SourcesDirectory)\src -includeDirectories Compilers\CSharp\Portable\Generated\, Compilers\VisualBasic\Portable\Generated\, ExpressionEvaluator\VisualBasic\Source\ResultProvider\Generated\ 
+      - powershell: eng/validate-code-formatting.ps1 -ci -rootDirectory $(Build.SourcesDirectory)\src -includeDirectories Compilers\CSharp\Portable\Generated\, Compilers\VisualBasic\Portable\Generated\, ExpressionEvaluator\VisualBasic\Source\ResultProvider\Generated\ 
         displayName: Validate Generated Syntax Files
         condition: or(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['compilerChange'], 'true'))
 
@@ -435,10 +423,10 @@ stages:
     steps:
       - template: eng/pipelines/checkout-windows-task.yml
 
-      - pwsh: eng/make-bootstrap.ps1 -output $(bootstrapDir)
+      - powershell: eng/make-bootstrap.ps1 -output $(bootstrapDir)
         displayName: Build Bootstrap Compiler
 
-      - pwsh: eng/test-determinism.ps1 -configuration Debug -bootstrapDir $(bootstrapDir)
+      - powershell: eng/test-determinism.ps1 -configuration Debug -bootstrapDir $(bootstrapDir) -ci
         displayName: Build - Validate determinism
 
       - template: eng/pipelines/publish-logs.yml
@@ -480,7 +468,7 @@ stages:
     steps:
       - template: eng/pipelines/checkout-unix-task.yml
 
-      - pwsh: eng/todo-check.ps1
+      - powershell: eng/todo-check.ps1
         displayName: Validate TODO/PROTOTYPE comments are not present
 
   - job: Correctness_Rebuild

docs/Language Feature Status.md

@@ -16,8 +16,8 @@ efforts behind them.
 | [Params Span\<T> + Stackalloc any array type](https://github.com/dotnet/csharplang/issues/1757) | [params-span](https://github.com/dotnet/roslyn/tree/features/params-span) | [In Progress](https://github.com/dotnet/roslyn/issues/57049) | [cston](https://github.com/cston) | TBD |  | [jaredpar](https://github.com/jaredpar) |
 | [Default in deconstruction](https://github.com/dotnet/roslyn/pull/25562) | [decon-default](https://github.com/dotnet/roslyn/tree/features/decon-default) | [In Progress](https://github.com/dotnet/roslyn/issues/25559) | [jcouv](https://github.com/jcouv) | [gafter](https://github.com/gafter) |  | [jcouv](https://github.com/jcouv) |
 | [Roles/Extensions](https://github.com/dotnet/csharplang/issues/5497) | [roles](https://github.com/dotnet/roslyn/tree/features/roles) | [In Progress](https://github.com/dotnet/roslyn/issues/66722) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [jjonescz](https://github.com/jjonescz) |  | [MadsTorgersen](https://github.com/MadsTorgersen) |
-| [Escape character](https://github.com/dotnet/csharplang/issues/7400) | N/A | [In Progress](https://github.com/dotnet/roslyn/pull/70497) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv), [RikkiGibson](https://github.com/RikkiGibson) |  | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | 
-| [Method group natural type improvements](https://github.com/dotnet/csharplang/blob/main/proposals/method-group-natural-type-improvements.md) | main | In Progress | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [cston](https://github.com/cston) |  | [jcouv](https://github.com/jcouv) |
+| [Escape character](https://github.com/dotnet/csharplang/issues/7400) | N/A | [Merged into 17.9p1](https://github.com/dotnet/roslyn/pull/70497) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv), [RikkiGibson](https://github.com/RikkiGibson) |  | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | 
+| [Method group natural type improvements](https://github.com/dotnet/csharplang/blob/main/proposals/method-group-natural-type-improvements.md) | main | [Merged into 17.9p2](https://github.com/dotnet/roslyn/issues/69432) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [cston](https://github.com/cston) |  | [jcouv](https://github.com/jcouv) |
 | [`Lock` object](https://github.com/dotnet/csharplang/issues/7104) | [LockObject](https://github.com/dotnet/roslyn/tree/features/LockObject) | [Merged into 17.10p2](https://github.com/dotnet/roslyn/issues/71888) | [jjonescz](https://github.com/jjonescz) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | | [stephentoub](https://github.com/stephentoub) |
 | Implicit indexer access in object initializers | main | [Merged into 17.9p3](https://github.com/dotnet/roslyn/pull/70649) | [jcouv](https://github.com/jcouv) | [AlekseyTs](https://github.com/AlekseyTs), [cston](https://github.com/cston) |  |  |
 

docs/contributing/Compiler Test Plan.md

@@ -49,7 +49,7 @@ This document provides guidance for thinking about language interactions and tes
 - fields (required and not)
 - properties (including get/set/init accessors, required and not)
 - events (including add/remove accessors)
-- Parameter modifiers (ref, out, in, ref readonly, params)
+- Parameter modifiers: ref, out, in, ref readonly, params (for array, for non-array)
 - Attributes (including generic attributes and security attributes)
 - Generics (type arguments, variance, constraints including `class`, `struct`, `new()`, `unmanaged`, `notnull`, types and interfaces with nullability)
 - Default and constant values