Merge 'main' into RefStructInterfaces #72519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Roslyn non-source-only build fixes These changes make it possible to build roslyn in non-source-only modes in the VMR: - Remove some vertical build (non-source-only) exclusions that were added during the PoC phase of the VMR - When packing the language server nuget package, Pack only the rid that the current vertical is building. - Mark a couple benchmark projects as IsTestProject. Tests are excluded by default when building the VMR - Mark a couple of test utility projects as test utility projects. When not building tests, these projects are excluded from the build. * Improve comments * Use ExcludeFromDotNetBuild instead of IsTestProject for benchmark projects * Add more comments * Update src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj Co-authored-by: Viktor Hofer <[email protected]> --------- Co-authored-by: Viktor Hofer <[email protected]>
…istAndPushOption
…/CyrusNajmabadi/roslyn into removeSolutionCrawlerIncremental
…wlerIncremental
Looking at profiles building Compilers.slnf locally found a number of places that we weren't using PooledBlobBuilder that were impacting allocations. This change removes 250MB of byte[] allocations and saves 50MB on LOH. This reduces time spent in GC during build by ~1 second. Note: profiling the compiler server is imprecise as due to the parallel nature of the server and msbuild profiles can be quite noisy. For these measurements I did several measurements and picked the most average for the comparisons.
This avoids full solution level searches in scenarios where a project cone is being searched. This was particularly bad when the AssetHint didn't indicate a project/document.
* Move to scout queue * Change corehost
dotnet-issue-labeler
bot
added
the
untriaged
cston
approved these changes
Mar 12, 2024
AlekseyTs
merged commit 3fde940
into
dotnet:features/RefStructInterfaces
31 checks passed
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.