Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer pattern-based over interface-based disposal in await using #72598

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Mar 19, 2024

Closes #72573

@jcouv jcouv self-assigned this Mar 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 19, 2024
@jcouv jcouv marked this pull request as ready for review March 20, 2024 21:18
@jcouv jcouv requested a review from a team as a code owner March 20, 2024 21:18
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1), assuming CI is passing.

@jcouv
Copy link
Member Author

jcouv commented Mar 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jcouv jcouv enabled auto-merge (squash) March 21, 2024 17:49
@jcouv jcouv merged commit 2f72b4d into dotnet:main Mar 21, 2024
24 of 27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 21, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.10 P3 Mar 25, 2024
@jcouv jcouv deleted the async-using branch April 1, 2024 15:43
jcouv added a commit to jcouv/roslyn that referenced this pull request Apr 1, 2024
jcouv added a commit to jcouv/roslyn that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent dispose behavior between await using and await foreach
4 participants