Don't try and add the result diagnostics if they are default or empty #74507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@dotnet/roslyn-ide for review please. Not sure where / how to add tests for this case. |
dibarbet
approved these changes
Jul 25, 2024
chsienki
added a commit
to chsienki/roslyn
that referenced
this pull request
Jul 25, 2024
chsienki
added a commit
that referenced
this pull request
Jul 26, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2152389
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2170891
This is a trivial fix and follow up from #74034
Don't know the IDE code well enough to craft a test to cover this though