Remove razor source generator hack #74651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
chsienki
commented
Aug 5, 2024
| @@ -282,7 +282,7 @@ private partial class RegularCompilationTracker : ICompilationTracker | |||
| if (compilationWithStaleGeneratedTrees != null) | |||
| { | |||
| var generatedTreeCount = | |||
| runResult.Results.Sum(r => IsGeneratorRunResultToIgnore(r) ? 0 : r.GeneratedSources.Length); | |||
| runResult.Results.Sum(r => r.GeneratedSources.IsDefaultOrEmpty ? 0 : r.GeneratedSources.Length); | |||
There was a problem hiding this comment.
This is another case of the bug that was fixed here: #74507
|
@dotnet/roslyn-ide for review please :) |
CyrusNajmabadi
approved these changes
Aug 5, 2024
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back we added a razor specific hack to remove any documents the razor SG generated. Razor is supposed to be able to operate in a 'suppressed' mode where it doesn't produce anything, but a bug in the generator meant it wasn't respecting that flag. Rather than trying to service the SDK we took a tactical hack to just remove the docs in Roslyn.
We're now at the point in razor co-hosting where we want razor to produce documents, but this hack of course just removes them. The razor SG is no longer loaded out of the SDK, but comes from tooling, where the suppression has been fixed, so this hack is no longer required anyway.