Remove unnecessary type for wrapping analyzer references. #74739
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| // Dispose of any analyzers that were removed now that we've applied the changes. | ||
| foreach (var analyzer in _analyzersRemovedInBatch) | ||
| { | ||
| analyzer.Dispose(); |
There was a problem hiding this comment.
no need to Dispose, as Dispose ended up doing nothing. Will demosntrate later.
| } | ||
| } | ||
|
|
||
| public void Dispose() |
There was a problem hiding this comment.
Here is the crux of this change. Note what DIspose does. It clears teh internal state of this type, grabs any load diagnostics produced... then DISCARDS them (loadErrors) is not read at all.
As such, this type does all this work to connect to events to listen for things that happen, only to utterly ignore them. As such, we can safely remove anything related to load errors. Since we can ignore those, we don't need to subscribe to AnalyzerLoadFailed event either. Which means this type has no purpose at all and can be entirely removed.
Note: perhaps it's a bug that we're missing LoadFailed errors. But that's the current state of the world, so this isn't making anything worse. If we do want to get these errors, we need that to likely happen in OOP, and have things reported from that end.
|
Does this mean this work item is completed? 🤔 |
|
@Cosifne Yup. I'll take care of that :) |
No description provided.