Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary type for wrapping analyzer references. #74739

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Remove unnecessary type for wrapping analyzer references. #74739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e12112e
Rename file and wrap long parameter list
CyrusNajmabadi Aug 13, 2024
1198ae8
Remove unnecessary type
CyrusNajmabadi Aug 13, 2024
7a808fc
Remove more
CyrusNajmabadi Aug 13, 2024
da36650
Update tests
CyrusNajmabadi Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EditorFeatures/Test2/IntelliSense/VisualBasicCompletionCommandHandlerTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,7 @@ End Class
End Using
End Function

<WpfFact()>
<WpfFact>
Public Async Function CompletionUpAfterLeftCurlyBrace() As Task
Using state = TestStateFactory.CreateVisualBasicTestState(
<document>
Expand All @@ -1424,7 +1424,7 @@ End Class
End Using
End Function

<WpfFact()>
<WpfFact>
Public Async Function CompletionUpAfterLeftAngleBracket() As Task
Using state = TestStateFactory.CreateVisualBasicTestState(
<document>
Expand Down Expand Up @@ -1653,7 +1653,7 @@ End Class
End Function

<WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/670149")>
<WpfFact()>
<WpfFact>
Public Sub TabAfterNullableFollowedByQuestionMark()
Using state = TestStateFactory.CreateVisualBasicTestState(
<Document><![CDATA[
Expand Down
2 changes: 1 addition & 1 deletion src/EditorFeatures/VisualBasicTest/AutomaticCompletion/AutomaticLineEnderTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ End Class</code>)
End Sub

<WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/712977")>
<WpfFact()>
<WpfFact>
Public Sub TestDim3()
Test(<code>Class C
Sub Method()
Expand Down
2 changes: 1 addition & 1 deletion src/EditorFeatures/VisualBasicTest/EndConstructGeneration/CharacterTypingTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ End Class]]>
endCaretPos:={3, 21})
End Sub

<WpfFact()>
<WpfFact>
Public Sub TestXmlEndConstructNotApplied()
VerifyEndConstructNotAppliedAfterChar(
before:=<Code>
Expand Down
1 change: 0 additions & 1 deletion ...ver/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/LanguageServerWorkspaceFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ public LanguageServerWorkspaceFactory(
var razorSourceGenerator = serverConfigurationFactory?.ServerConfiguration?.RazorSourceGenerator;
ProjectSystemHostInfo = new ProjectSystemHostInfo(
DynamicFileInfoProviders: dynamicFileInfoProviders.ToImmutableArray(),
ProjectSystemDiagnosticSource.Instance,
new HostDiagnosticAnalyzerProvider(razorSourceGenerator));

TargetFrameworkManager = projectTargetFrameworkManager;
Expand Down
22 changes: 0 additions & 22 deletions ...rver/Microsoft.CodeAnalysis.LanguageServer/HostWorkspace/ProjectSystemDiagnosticSource.cs
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/VisualStudio/Core/Def/ProjectSystem/VisualStudioProjectFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
using Microsoft.CodeAnalysis.Workspaces.ProjectSystem;
using Microsoft.VisualStudio.LanguageServices.ExternalAccess.VSTypeScript.Api;
using Microsoft.VisualStudio.LanguageServices.Implementation.Diagnostics;
using Microsoft.VisualStudio.LanguageServices.Implementation.TaskList;
using Microsoft.VisualStudio.Shell;
using Microsoft.VisualStudio.Shell.Interop;
using Microsoft.VisualStudio.Telemetry;
Expand Down Expand Up @@ -94,7 +93,7 @@ public async Task<ProjectSystemProject> CreateAndAddToWorkspaceAsync(
_visualStudioWorkspaceImpl.ProjectSystemProjectFactory.SolutionPath = solutionFilePath;
_visualStudioWorkspaceImpl.ProjectSystemProjectFactory.SolutionTelemetryId = GetSolutionSessionId();

var hostInfo = new ProjectSystemHostInfo(_dynamicFileInfoProviders, HostDiagnosticUpdateSource.Instance, vsixAnalyzerProvider);
var hostInfo = new ProjectSystemHostInfo(_dynamicFileInfoProviders, vsixAnalyzerProvider);
var project = await _visualStudioWorkspaceImpl.ProjectSystemProjectFactory.CreateAndAddToWorkspaceAsync(projectSystemName, language, creationInfo, hostInfo);

_visualStudioWorkspaceImpl.AddProjectToInternalMaps(project, creationInfo.Hierarchy, creationInfo.ProjectGuid, projectSystemName);
Expand Down
23 changes: 0 additions & 23 deletions src/VisualStudio/Core/Def/TaskList/HostDiagnosticUpdateSource.cs
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions src/VisualStudio/Core/Test/ProjectSystemShim/VisualBasicCompilerOptionsTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub SetCompilerOptions_LangVersion14()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -73,7 +73,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub SetCompilerOptions_LangVersion15()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -96,7 +96,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub SetCompilerOptions_LangVersionDefault()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -116,7 +116,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub SetCompilerOptions_LangVersion15_3()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -136,7 +136,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub SetCompilerOptions_LangVersionLatest()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand Down
4 changes: 2 additions & 2 deletions src/VisualStudio/Core/Test/ProjectSystemShim/VisualBasicProjectTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
<[UseExportProvider]>
<Trait(Traits.Feature, Traits.Features.ProjectSystemShims)>
Public Class VisualBasicProjectTests
<WpfFact()>
<WpfFact>
Public Sub RenameProjectUpdatesWorkspace()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -27,7 +27,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub DisconnectingAProjectDoesNotLeak()
Using environment = New TestEnvironment()
Dim project = ObjectReference.CreateFromFactory(Function() CreateVisualBasicProject(environment, "Test"))
Expand Down
6 changes: 3 additions & 3 deletions src/VisualStudio/Core/Test/ProjectSystemShim/VisualBasicSpecialReferencesTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
<[UseExportProvider]>
<Trait(Traits.Feature, Traits.Features.ProjectSystemShims)>
Public Class VisualBasicSpecialReferencesTests
<WpfFact()>
<WpfFact>
Public Sub ProjectIncludesReferencesToMscorlibSystemAndMicrosoftVisualBasic()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -29,7 +29,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub ProjectWithoutStandardLibsDoesNotReferenceSystem()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand All @@ -48,7 +48,7 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.ProjectSystemShim
End Using
End Sub

<WpfFact()>
<WpfFact>
Public Sub ProjectWithoutVisualBasicRuntimeDoesNotReferenceMicrosoftVisualBasic()
Using environment = New TestEnvironment()
Dim project = CreateVisualBasicProject(environment, "Test")
Expand Down
74 changes: 0 additions & 74 deletions src/VisualStudio/Core/Test/ProjectSystemShim/VisualStudioAnalyzerTests.vb
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/Workspaces/Core/Portable/Workspace/ProjectSystem/IProjectSystemDiagnosticSource.cs
View file
Open in desktop

This file was deleted.

Loading
Loading