Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Razor to 9.0.0-preview.24555.12 #75794

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

davidwengier
Copy link
Contributor

The previous bump was because of a serialization change from v6 to v7. Sadly RPS meant that change got reverted, so this takes us back to v6.

I suspect we'll be back at v7 soon, but preparing this so Razor insertions are not otherwise blocked.

@davidwengier davidwengier requested a review from a team as a code owner November 6, 2024 22:20
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 6, 2024
@dibarbet
Copy link
Member

dibarbet commented Nov 8, 2024

@davidwengier does this need to go in before we can insert roslyn into vscode? theres a high pri change we need to get in before snap on friday

@davidwengier
Copy link
Contributor Author

No, current inserted razor works with current builds of Roslyn. This will be needed if we have to take a newer razor though

@dibarbet
Copy link
Member

dibarbet commented Nov 8, 2024

No, current inserted razor works with current builds of Roslyn. This will be needed if we have to take a newer razor though

We will be taking a newer version of Razor for the telemetry fix as well - this is the change - dotnet/razor#11181

@davidwengier if this change is required for that, please merge (otherwise hold off)

@davidwengier
Copy link
Contributor Author

I think @ryzngard did the right thing with that one, I think it should be fine to not take this. In fact, taking this would break that!

@ryzngard
Copy link
Contributor

I think @ryzngard did the right thing with that one, I think it should be fine to not take this. In fact, taking this would break that!

They in fact did not....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants