Failure to build pri-1 tests #81984
Assignees
Labels
area-Infrastructure-coreclr
blocking
Marks issues that we want to fast track in order to unblock other important work
Milestone
Comments
BruceForstall
added
blocking
|
Tagging subscribers to this area: @hoyosjs Issue DetailsIn particular, HardwareIntrinsics tests. Build commands: Errors: Presumably this doesn't happen in the Linux builds where the CI builds the tests? Unfortunately, we build in "test groups" and the build doesn't continue past this failing test group to build other tests in subsequent test groups.
|
|
Note that I always build with: set in my environment. Perhaps these are (now) incompatible with that mode? (If so, can we make them compatible with that mode?) |
I'm not seeing a failure when building without that, but can repro with it. I'm unsure how |
|
Hmm, I'll take a look, |
|
Do tests need to be written to support setting If |
|
For ilproj tests, even after merging they still include |
|
I can see these errors now on a new merging PR but they weren't there when I merged IL_Conformance and run outer loop. Was there any update on Xunit? |
|
I found two issues:
|
ghost
added
the
in-pr
ghost
removed
the
in-pr
33 tasks
|
@markples Do you expect to have a fix for this anytime soon? |
|
@BruceForstall This is fairly high priority, along with some of the checks to ensure that we run all tests. However, I have more investigation to do here as my attempts to work with OutputType have only made things worse so far. |
ghost
added
the
in-pr
markples
added a commit
that referenced
this issue
Apr 6, 2023
This should fix test builds with `set BuildAsStandalone=true`. - [Remove](5f14f05) unconditional `<BuildAsStandalone>false</BuildAsStandalone>` from various HardwareIntrinsics tests. This is already the default via Directory.Build.props but interferes with `set BuildAsStandalone=true`. (nit - also remove an empty `PropertyGroup` from GitHub_43569.csproj) - [Remove `Main` methods](0a886f8). We might be able to pursue a strategy where the test author provides a `Main(args)` method for local custom execution. The test would either need a separate parameterless [Fact] method or a [Theory] plus data for `Main` for merged group to execute it. However, a RequiresProcessIsolation/BuildAsStandalone build would ignore that metadata, so I'd like to avoid that complexity. The Main methods here set a bool or parse an int, which can be added locally to any test as needed. - [Add comment](e79a10c) to Directory.Merged.props (addressing feedback on #83462) - [Add the Methodical test back into the superpmi test](7c61de8) using RequiresProcessIsolation Fixes #76421 Fixes #81984
ghost
removed
the
in-pr
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In particular, HardwareIntrinsics tests.
Build commands (on Windows):
Errors:
Presumably this doesn't happen in the Linux builds where the CI builds the tests?
Unfortunately, we build in "test groups" and the build doesn't continue past this failing test group to build other tests in subsequent test groups.
@tannergooding
The text was updated successfully, but these errors were encountered: