Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BuildAsStandalone=true for tests in merged groups #82287

Closed
wants to merge 2 commits into from

Conversation

markples
Copy link
Member

@markples markples commented Feb 17, 2023

  • Stop unconditionally settings BuildAsStandalone=false in the individual HardwareIntrinsics tests. This overrides an environment variable setting BuildAsStandalone=true (but not msbuild /p). The HardwareIntrinsics Directory.Build.props already sets BuildAsStandalone=false as a default. (from Hardware intrinsics tests in new style #74886)
  • Add BuildAsStandalone to the check in the top-level Directory.Build.props for setting OutputType=Exe. It already included RequiresProcessIsolation. Note that there is already code for IsMergedTestRunnerAssembly cases checking that they are not BuildAsStandalone, so this new logic is only applied to non-IsMergedTestRunnerAssembly cases.

Fixes #81984

@ghost
Copy link

ghost commented Feb 17, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Stop unconditionally settings BuildAsStandalone=false in the individual HardwareIntrinsics tests. This overrides an environment variable setting BuildAsStandalone=true (but not msbuild /p). The HardwareIntrinsics Directory.Build.props already sets BuildAsStandalone=false as a default. (from Hardware intrinsics tests in new style #74886)
  • Add BuildAsStandalone to the check in the top-level Directory.Build.props for setting OutputType=Exe. It already included RequiresProcessIsolation. Note that there is already code for IsMergedTestRunnerAssembly cases checking that they are not BuildAsStandalone, so this new logic is only applied to non-IsMergedTestRunnerAssembly cases.
Author: markples
Assignees: markples
Labels:

area-System.Runtime.Intrinsics

Milestone: -

@markples markples added the test-bug Problem in test source code (most likely) label Feb 17, 2023
@markples
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Mar 19, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Mar 19, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.Intrinsics test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to build pri-1 tests
1 participant